From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Thomas Abraham <thomas.abraham@linaro.org>
Cc: Jingoo Han <jg1.han@samsung.com>,
Kukjin Kim <kgene.kim@samsung.com>,
linux-samsung-soc@vger.kernel.org, linux-pci@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org,
Surendranath Gurivireddy Balla <suren.reddy@samsung.com>,
Siva Reddy Kallam <siva.kallam@samsung.com>
Subject: Re: [PATCH 1/2] ARM: EXYNOS: Add PCIe driver support
Date: Wed, 6 Mar 2013 14:07:52 +0100 [thread overview]
Message-ID: <20130306140752.7e5d68c8@skate> (raw)
In-Reply-To: <CAJuYYwTKe6cC+eMmyAAskCJrDrbS3SmYRYhzL9iui5m1zvgbzw@mail.gmail.com>
Dear Thomas Abraham,
On Mon, 4 Mar 2013 16:01:59 +0530, Thomas Abraham wrote:
> On 4 March 2013 15:52, Jingoo Han <jg1.han@samsung.com> wrote:
> > Exynos5440 has two PCIe controllers which can be used as Root Complex.
> > This driver supports the PCIe controllers as Root Complex mode.
> >
> > Signed-off-by: Surendranath Gurivireddy Balla <suren.reddy@samsung.com>
> > Signed-off-by: Siva Reddy Kallam <siva.kallam@samsung.com>
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> > ---
> > .../devicetree/bindings/pci/exynos-pcie.txt | 58 ++
> > arch/arm/Kconfig | 2 +
> > arch/arm/mach-exynos/Kconfig | 8 +
> > arch/arm/mach-exynos/Makefile | 2 +
> > arch/arm/mach-exynos/include/mach/pcie.h | 146 +++
> > arch/arm/mach-exynos/pcie.c | 1009 ++++++++++++++++++++
>
> Is there any reason to place this code in arch/arm/...? As you know,
> there is a constant effort to relocate as much code as possible from
> arch/arm/mach-exynos. So there must be a strong justification for
> keeping this code in arch/arm/mach-exynos.
Indeed. Thierry Reding (doing the Tegra PCIe driver) and myself (doing
the Marvell PCIe driver) are putting our drivers in drivers/pci/host/,
in agreement with the PCI maintainers.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-03-06 13:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 10:22 [PATCH 1/2] ARM: EXYNOS: Add PCIe driver support Jingoo Han
2013-03-04 10:23 ` [PATCH 2/2] ARM: dts: Add pcie controller node for Samsung EXYNOS5440 SoC Jingoo Han
2013-03-04 10:31 ` [PATCH 1/2] ARM: EXYNOS: Add PCIe driver support Thomas Abraham
2013-03-06 13:07 ` Thomas Petazzoni [this message]
2013-03-07 1:17 ` Kukjin Kim
2013-03-06 8:48 ` Andrew Murray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130306140752.7e5d68c8@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=jg1.han@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=siva.kallam@samsung.com \
--cc=suren.reddy@samsung.com \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.