From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [blkback] blkback statistic counters are signed values Date: Wed, 6 Mar 2013 10:41:01 -0500 Message-ID: <20130306154101.GC12500@phenom.dumpdata.com> References: <5134C3C2.6040108@citrix.com> <20130304192246.GH15386@phenom.dumpdata.com> <5136344F.7040602@citrix.com> <51372503.6080806@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <51372503.6080806@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: David Vrabel Cc: "xen-devel@lists.xensource.com" , Zoltan Kiss List-Id: xen-devel@lists.xenproject.org On Wed, Mar 06, 2013 at 11:14:11AM +0000, David Vrabel wrote: > On 05/03/13 18:07, Zoltan Kiss wrote: > > Hi, > > > > On 04/03/13 19:22, Konrad Rzeszutek Wilk wrote: > >> Seems like the right approach. Could you send a patch please? > > I just sent it to you and linux-kernel@vger.kernel.org: > > > > http://lkml.indiana.edu/hypermail/linux/kernel/1303.0/02306.html > > > >> Thought that won't solve the problem when we overflow an 'unsigned > >> long long'. > > Well, I think it's good enough if the users of these values pay > > attention, and poll these sysfs entries often enough to detect that > > there was an overflow. > > Unless my maths is wrong it will take millions of years for these sector > count statistics to overflow. OK, so you are saying like Bill Gates, that this ought to be enough :-) I will take that as an Acked-by :-) > > David