From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 20/28] drm/i915: don't enumerate VGA on VLV
Date: Wed, 6 Mar 2013 21:14:14 +0200
Message-ID: <20130306191414.GM4469@intel.com>
References: <1362172471-7643-1-git-send-email-jbarnes@virtuousgeek.org>
	<1362172471-7643-21-git-send-email-jbarnes@virtuousgeek.org>
	<20130306190011.GK4469@intel.com>
	<20130306110908.1726bf1f@jbarnes-desktop>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
	by gabe.freedesktop.org (Postfix) with ESMTP id 6AC52E5C8A
	for <intel-gfx@lists.freedesktop.org>;
	Wed,  6 Mar 2013 11:14:17 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20130306110908.1726bf1f@jbarnes-desktop>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Mar 06, 2013 at 11:09:08AM -0800, Jesse Barnes wrote:
> On Wed, 6 Mar 2013 21:00:11 +0200
> Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com> wrote:
> =

> > On Fri, Mar 01, 2013 at 01:14:23PM -0800, Jesse Barnes wrote:
> > > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> > > ---
> > >  drivers/gpu/drm/i915/intel_display.c |    3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > =

> > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i=
915/intel_display.c
> > > index fd4a0d4..60397e8 100644
> > > --- a/drivers/gpu/drm/i915/intel_display.c
> > > +++ b/drivers/gpu/drm/i915/intel_display.c
> > > @@ -8503,7 +8503,8 @@ static void intel_setup_outputs(struct drm_devi=
ce *dev)
> > >  		I915_WRITE(PFIT_CONTROL, 0);
> > >  	}
> > >  =

> > > -	if (!(HAS_DDI(dev) && (I915_READ(DDI_BUF_CTL(PORT_A)) & DDI_A_4_LAN=
ES)))
> > > +	if (!(HAS_DDI(dev) && (I915_READ(DDI_BUF_CTL(PORT_A)) & DDI_A_4_LAN=
ES)) &&
> > > +	    !IS_VALLEYVIEW(dev))
> > >  		intel_crt_init(dev);
> > =

> > I was under the impression that VLV still has this. Was I mistaken?
> =

> Not exposed anymore I think.  And yeah this can be dropped since the
> DDI check should dtrt.

It's testing for !HAS_DDI() which should equal true for VLV.

-- =

Ville Syrj=E4l=E4
Intel OTC