From: Olaf Hering <olaf@aepfle.de>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <Ian.Campbell@citrix.com>,
Marcus Granado <marcus.granado@citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH] tools/xenconsoled: Initialise pointers before trying to use them
Date: Thu, 7 Mar 2013 16:28:28 +0100 [thread overview]
Message-ID: <20130307152828.GA28806@aepfle.de> (raw)
In-Reply-To: <f66d74cbf49244d97957.1362669196@andrewcoop.uk.xensource.com>
On Thu, Mar 07, Andrew Cooper wrote:
> This is a regression introduced by
>
> "Switch from select() to poll() in xenconsoled's IO loop."
> hg c/s 26405:7359c3122c5d
> git cc5434c933153c4b8812d1df901f8915c22830a8
>
> which results in reliable segfaults during VM power operations.
What about switching to calloc(3), given that many members are zeroed
anyway?
Olaf
next prev parent reply other threads:[~2013-03-07 15:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 15:13 [PATCH] tools/xenconsoled: Initialise pointers before trying to use them Andrew Cooper
2013-03-07 15:28 ` Olaf Hering [this message]
2013-03-07 15:57 ` Andrew Cooper
2013-03-07 16:20 ` Wei Liu
2013-03-07 16:22 ` Andrew Cooper
2013-03-07 17:15 ` Wei Liu
2013-03-07 17:46 ` Andrew Cooper
2013-03-07 18:07 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130307152828.GA28806@aepfle.de \
--to=olaf@aepfle.de \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=marcus.granado@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.