From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38195) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDhL7-0008LN-Cp for qemu-devel@nongnu.org; Thu, 07 Mar 2013 15:23:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UDhL4-0000dC-IA for qemu-devel@nongnu.org; Thu, 07 Mar 2013 15:22:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55177) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDhL4-0000cy-AS for qemu-devel@nongnu.org; Thu, 07 Mar 2013 15:22:54 -0500 Date: Thu, 7 Mar 2013 22:23:09 +0200 From: "Michael S. Tsirkin" Message-ID: <20130307202309.GA13088@redhat.com> References: <20130307184647.GA31012@redhat.com> <87d2vbx9rz.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87d2vbx9rz.fsf@blackfin.pond.sub.org> Subject: Re: [Qemu-devel] [PATCH v4] qdev: DEVICE_DELETED event List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Kevin Wolf , Anthony Liguori , Eduardo Habkost , libvir-list@redhat.com, Stefan Hajnoczi , qemu-devel@nongnu.org, Luiz Capitulino , Gerd Hoffmann , Paolo Bonzini , Andreas =?iso-8859-1?Q?F=E4rber?= On Thu, Mar 07, 2013 at 08:57:52PM +0100, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > libvirt has a long-standing bug: when removing the device, > > it can request removal but does not know when the > > removal completes. Add an event so we can fix this in a robust way. > > > > Signed-off-by: Michael S. Tsirkin > > Speaking as the acting QMP maintainer, just to avoid misunderstandings: > there's disagreement on the event's design, namely when it should fire, > and how it should name the device. I don't want the discussion > preempted by a commit. Yes, you are asking for more functionality, but can I add this in a follow-up commit please? I prefer this patch as is, as it can be backported to stable branches and downstreams. Upstream a follow up patch can add fields and more triggers which won't apply to any downstreams. This patch will help resolve a set of serious long-standing bugs, see e.g. https://bugzilla.redhat.com/show_bug.cgi?id=813748 -- MST