From: Dave Chinner <david@fromorbit.com>
To: dsterba@suse.cz, Wang Sheng-Hui <shhuiw@gmail.com>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests 273: fix a typo
Date: Fri, 8 Mar 2013 09:48:32 +1100 [thread overview]
Message-ID: <20130307224832.GV23616@dastard> (raw)
In-Reply-To: <20130307110600.GJ21081@twin.jikos.cz>
On Thu, Mar 07, 2013 at 12:06:01PM +0100, David Sterba wrote:
> On Thu, Mar 07, 2013 at 02:38:49PM +1100, Dave Chinner wrote:
> > On Thu, Mar 07, 2013 at 12:22:22AM +0100, David Sterba wrote:
> > > On Wed, Feb 27, 2013 at 02:47:54PM +0800, Wang Sheng-Hui wrote:
> > > > - cp -r $SCRATCH_MNT/origin $SCRATCH_MNT/sub_$_suffix >$seq.full 2>&1
> > > > + cp -r $SCRATCH_MNT/origin $SCRATCH_MNT/sub_$_suffix >>$seq.full 2>&1
>
> This is quote from the mail, but the merged patch does something else.
>
> > > +./273: line 95: syntax error near unexpected token `&'
> > > +./273: line 95: ` cp -r $SCRATCH_MNT/origin $SCRATCH_MNT/sub_$_suffix >$seq.full 2>>&1'
> > > +umount: /dev/sda9: not mounted
>
> > that seems rather strange. The patch does this:
> >
> > ....sub_$_suffix >>$seq.full 2>&1
>
> http://oss.sgi.com/cgi-bin/gitweb.cgi?p=xfs/cmds/xfstests.git;a=commitdiff;h=0c5e67e46e476b70290033efc7feb784f7ecbab1;hp=08557e219c12e573be459407033495899f46967a
Oh....
> ---
>
> > and the error output you see is
> >
> > ....sub_$_suffix >$seq.full 2>>&1
> >
> > So it doesn't look lie you are running with the change that is
> > actually in the patch...
>
> There's a difference between the patch in mail and what has been merged, that
> can happen, but I wonder why it works on your side.
.... because I haven't updated to the latest xfstests master branch
yet - I'm running with the patch from the list applied. I didn't
realise you were running from the main repo, and that the commit was
busted...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-03-07 22:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-27 6:47 [PATCH] xfstests 273: fix a typo Wang Sheng-Hui
2013-02-27 23:05 ` Dave Chinner
2013-03-06 23:22 ` David Sterba
2013-03-07 3:38 ` Dave Chinner
2013-03-07 11:06 ` David Sterba
2013-03-07 11:22 ` David Sterba
2013-03-07 22:48 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130307224832.GV23616@dastard \
--to=david@fromorbit.com \
--cc=dsterba@suse.cz \
--cc=shhuiw@gmail.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.