All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: David Miller <davem@davemloft.net>
Cc: ming.lei@canonical.com, jkosina@suse.cz,
	stern@rowland.harvard.edu, oneukum@suse.de,
	netdev@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-input@vger.kernel.org
Subject: Re: [PATCH v2 0/7] USB: don't recover device if suspend fails in system sleep
Date: Fri, 8 Mar 2013 07:24:01 +0800	[thread overview]
Message-ID: <20130307232401.GC10304@kroah.com> (raw)
In-Reply-To: <20130307.152807.2038557949816610391.davem@davemloft.net>

On Thu, Mar 07, 2013 at 03:28:07PM -0500, David Miller wrote:
> From: Ming Lei <ming.lei@canonical.com>
> Date: Fri,  8 Mar 2013 00:15:17 +0800
> 
> > This patch adds comments on interface driver suspend callback
> > to emphasize that the failure return value is ignored by
> > USB core in system sleep context, so do not try to recover
> > device for this case, otherwise the recovery things may confuse
> > resume().
> > 
> > Also fixes the USB serial, HID and several usbnet drivers
> > which may recover device in suspend failure path of system sleep.
> > 
> > v2:
> > 	- improve comments on suspend callback as suggested by Alan
> > 	- update kerneldoc for usb_suspend_both as suggested by Alan
> > 	- remove previous check of PMSG_IS_AUTO(message) in cdc_mbim/
> > 	qmi_wwan and add comments on suspend failure case, since Bjørn
> > 	doesn't like the check.
> > 	- add comments on smsc95xx/smsc75xx
> > v1:
> >         - fix compile failure
> >         - add comments about handling suspend failure in resume()
> 
> Feel free to merge this via the USB tree and to add my ACK to the
> networking driver bits:
> 
> Acked-by: David S. Miller <davem@davemloft.net>

Thanks, I will do that.

greg k-h

      reply	other threads:[~2013-03-07 23:24 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-07 16:15 [PATCH v2 0/7] USB: don't recover device if suspend fails in system sleep Ming Lei
     [not found] ` <1362672924-22975-1-git-send-email-ming.lei-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2013-03-07 16:15   ` [PATCH v2 1/7] USB: adds comment on suspend callback Ming Lei
2013-03-07 20:26     ` Alan Stern
2013-03-07 20:26       ` Alan Stern
2013-03-07 16:15   ` [PATCH v2 4/7] usbnet: cdc_mbim: comments on suspend failure Ming Lei
2013-03-07 18:08     ` Bjørn Mork
2013-03-07 16:15   ` [PATCH v2 5/7] usbnet: qmi_wwan: " Ming Lei
2013-03-07 18:08     ` Bjørn Mork
2013-03-07 16:15 ` [PATCH v2 2/7] USB: serial: handle suspend failure path correctly Ming Lei
2013-03-14 11:10   ` Johan Hovold
2013-03-15  3:04     ` Ming Lei
2013-03-07 16:15 ` [PATCH v2 3/7] USBHID: don't recover device if suspend fails in system sleep Ming Lei
2013-03-07 23:16   ` Jiri Kosina
2013-03-07 23:48     ` Greg Kroah-Hartman
2013-03-07 16:15 ` [PATCH v2 6/7] usbnet: smsc95xx: " Ming Lei
2013-03-07 16:15 ` [PATCH v2 7/7] usbnet: smsc75xx: " Ming Lei
2013-03-07 20:28 ` [PATCH v2 0/7] USB: " David Miller
2013-03-07 23:24   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130307232401.GC10304@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=davem@davemloft.net \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=ming.lei@canonical.com \
    --cc=netdev@vger.kernel.org \
    --cc=oneukum@suse.de \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.