All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org
Subject: Re: Mixup with name_len & file_type in e2fsprogs
Date: Thu, 7 Mar 2013 19:44:38 -0500	[thread overview]
Message-ID: <20130308004438.GA29720@thunk.org> (raw)
In-Reply-To: <20130307182444.GA21237@quack.suse.cz>

On Thu, Mar 07, 2013 at 07:24:44PM +0100, Jan Kara wrote:
>   I was thinking some more about it. Won't it be cleaner (and not much
> harder) if we always used ext2_dir_entry_2 in e2fsprogs and properly did
> byte swapping of name_len only if FILETYPE feature isn't enabled? I've
> checked and it would mean changing prototypes of like 8 functions in
> ext2fs.h (or better provide new functions with struct ext2_dir_entry_2
> argument) which doesn't seem too bad... This solution seems to be the least
> surprising to the users of libext2fs (esp. if they do some scanning of
> directory blocks themselves or so).

What worries me is potential ABI breackages if we try to redefine
existing interfaces as using ext2_dir_entry_2.  And I'm not convinced
it's worth it to create new versions of the functions that use the new
structure.  This is why I suggested using accessor functions....

	    	    	  	    	  	   - Ted

  parent reply	other threads:[~2013-03-08  0:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-05 12:18 Mixup with name_len & file_type in e2fsprogs Jan Kara
2013-03-05 18:29 ` Theodore Ts'o
2013-03-05 18:41   ` Jan Kara
2013-03-07 18:24     ` Jan Kara
2013-03-07 23:00       ` Andreas Dilger
2013-03-08  0:44       ` Theodore Ts'o [this message]
2013-03-08  0:46       ` Theodore Ts'o
2013-03-11 14:18         ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130308004438.GA29720@thunk.org \
    --to=tytso@mit.edu \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.