From: Johan Hedberg <johan.hedberg@gmail.com>
To: Andre Guedes <andre.guedes@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2 6/6] Bluetooth: Check req->err in hci_req_add
Date: Fri, 8 Mar 2013 09:50:09 +0200 [thread overview]
Message-ID: <20130308075009.GB817@x220> (raw)
In-Reply-To: <1362692892-28716-7-git-send-email-andre.guedes@openbossa.org>
Hi Andre,
On Thu, Mar 07, 2013, Andre Guedes wrote:
> + if (req->err)
> + return;
Same thing here with the error check, I think if (err < 0) is more
consistent.
Johan
next prev parent reply other threads:[~2013-03-08 7:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 21:48 [PATCH v2 0/6] Error handling in HCI request framework Andre Guedes
2013-03-07 21:48 ` [PATCH v2 1/6] Bluetooth: Fix __hci_req_sync Andre Guedes
2013-03-07 21:48 ` [PATCH v2 2/6] Bluetooth: Return ENODATA in hci_req_run Andre Guedes
2013-03-07 21:48 ` [PATCH v2 3/6] Bluetooth: Check hci_req_run returning value in __hci_req_sync Andre Guedes
2013-03-07 21:48 ` [PATCH v2 4/6] Bluetooth: HCI request error handling Andre Guedes
2013-03-08 7:49 ` Johan Hedberg
2013-03-07 21:48 ` [PATCH v2 5/6] Bluetooth: Make hci_req_add returning void Andre Guedes
2013-03-07 21:48 ` [PATCH v2 6/6] Bluetooth: Check req->err in hci_req_add Andre Guedes
2013-03-08 7:50 ` Johan Hedberg [this message]
2013-03-08 11:08 ` Andrei Emeltchenko
2013-03-08 11:25 ` Johan Hedberg
2013-03-08 11:34 ` Johan Hedberg
2013-03-08 14:07 ` Andre Guedes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130308075009.GB817@x220 \
--to=johan.hedberg@gmail.com \
--cc=andre.guedes@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.