From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Daniel Mack <zonque@gmail.com>
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com
Subject: Re: [PATCH] ALSA: ASoC: add codec driver for TI TAS5086
Date: Fri, 8 Mar 2013 20:30:08 +0800 [thread overview]
Message-ID: <20130308123006.GH28481@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <5139D8FB.4070500@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 597 bytes --]
On Fri, Mar 08, 2013 at 01:26:35PM +0100, Daniel Mack wrote:
> On 08.03.2013 12:42, Mark Brown wrote:
> > Please avoid the ternery operator. It'd be nice to switch over to
> > mute_stream() too.
> I wasn't aware of steam_mute. How's that supposed to be used? I'm asking
> because when using 4-channel playback, the driver gets this callback for
> stream == 0 only. Am I supposed to (un)mute all channels here,
> regardless of the stream parameter passed in?
The stream parameter is _PLAYBACK or _CAPTURE - it's just the same as
digital_mute() except it can be applied to a capture stream too.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2013-03-08 12:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-08 11:07 [PATCH] ALSA: ASoC: add codec driver for TI TAS5086 Daniel Mack
2013-03-08 11:42 ` Mark Brown
2013-03-08 12:26 ` Daniel Mack
2013-03-08 12:30 ` Mark Brown [this message]
2013-03-08 12:31 ` Daniel Mack
2013-05-22 17:50 ` jonsmirl
2013-05-22 17:55 ` Daniel Mack
2013-05-22 18:01 ` jonsmirl
2013-05-22 18:20 ` jonsmirl
2013-05-22 18:24 ` jonsmirl
2013-05-22 18:25 ` Daniel Mack
2013-05-22 18:33 ` jonsmirl
2013-05-22 18:36 ` Daniel Mack
2013-05-22 19:31 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130308123006.GH28481@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.