From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Markus Pargmann <mpa@pengutronix.de>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
patches@opensource.wolfsonmicro.com, linux-input@vger.kernel.org,
kernel@pengutronix.de, stable@vger.kernel.org
Subject: Re: [PATCH 1/4] Input: wm97xx: Drop out of range inputs
Date: Sat, 9 Mar 2013 01:15:49 +0800 [thread overview]
Message-ID: <20130308171538.GA26088@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1362759309-18782-2-git-send-email-mpa@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 463 bytes --]
On Fri, Mar 08, 2013 at 05:15:06PM +0100, Markus Pargmann wrote:
> + if (
> + abs_x[0] > (data.x & 0xfff)
> + || abs_x[1] < (data.x & 0xfff)
> + || abs_y[0] > (data.y & 0xfff)
> + || abs_y[1] < (data.y & 0xfff)) {
> + dev_dbg(wm->dev, "Measurement out of range, dropping it\n");
> + rc = RC_AGAIN;
> + goto out;
The change is good but not a fan of the coding style here. Otherwise
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-03-08 17:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-08 16:15 [PATCH 0/4] Input: wm97xx: Fix handling of wrong readings Markus Pargmann
2013-03-08 16:15 ` [PATCH 1/4] Input: wm97xx: Drop out of range inputs Markus Pargmann
2013-03-08 17:15 ` Mark Brown [this message]
2013-03-08 18:11 ` Markus Pargmann
2013-03-08 16:15 ` [PATCH 2/4] Input: wm9712: Fix returncode for wrong sample Markus Pargmann
2013-03-08 17:17 ` Mark Brown
2013-03-08 16:15 ` [PATCH 3/4] Input: wm9712: Fix wrong pen up readings Markus Pargmann
2013-03-08 17:23 ` Mark Brown
2013-03-08 16:15 ` [PATCH 4/4] Input: wm9712: Fix dev_dbg newlines Markus Pargmann
2013-03-08 17:21 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130308171538.GA26088@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=dmitry.torokhov@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-input@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=mpa@pengutronix.de \
--cc=patches@opensource.wolfsonmicro.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.