From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from moutng.kundenserver.de ([212.227.17.9]:59677 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751264Ab3CHUPV (ORCPT ); Fri, 8 Mar 2013 15:15:21 -0500 Date: Fri, 8 Mar 2013 21:13:40 +0100 From: Thierry Reding To: Jason Gunthorpe Cc: Mitch Bradley , Lior Amsalem , Russell King - ARM Linux , Jason Cooper , Andrew Lunn , linux-pci@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, Eran Ben-Avi , Nadav Haklai , Maen Suleiman , Bjorn Helgaas , Shadi Ammouri , Tawfik Bayouk , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 24/32] pci: PCIe driver for Marvell Armada 370/XP systems Message-ID: <20130308201339.GA26322@avionic-0098.mockup.avionic-design.de> References: <20130307174955.GC20840@obsidianresearch.com> <20130307194830.GA1811@avionic-0098.mockup.avionic-design.de> <20130307200235.GB20695@obsidianresearch.com> <20130307204726.GB1811@avionic-0098.mockup.avionic-design.de> <51392B4D.9040404@gmail.com> <20130308071443.GA5772@avionic-0098.mockup.avionic-design.de> <20130308165228.GB4094@obsidianresearch.com> <20130308191227.GA6551@avionic-0098.mockup.avionic-design.de> <513A3F4F.2090501@firmworks.com> <20130308200245.GC29435@obsidianresearch.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="82I3+IH0IqGh5yIs" In-Reply-To: <20130308200245.GC29435@obsidianresearch.com> Sender: linux-pci-owner@vger.kernel.org List-ID: --82I3+IH0IqGh5yIs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 08, 2013 at 01:02:46PM -0700, Jason Gunthorpe wrote: > On Fri, Mar 08, 2013 at 09:43:11AM -1000, Mitch Bradley wrote: [...] > > 2) The "@0,0" and "@1,0" suffixes do not correspond to the reg values > > <0x0800 0 0 0 0> and <0x1000 0 0 0 0> using any rule that I know. >=20 > @0,1,0 (bus,device,fn) could be more appropriate, but that is > cosmetic? The OF PCI specification is pretty strict about this as well. It says in section 2.2.1.3. that only the DD and DD,FF forms can appear in a device path. Thierry --82I3+IH0IqGh5yIs Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQIcBAEBAgAGBQJROkZzAAoJEN0jrNd/PrOhjOYQAK2XmBbA+p5sqjGBjfDOxGc/ Q3Amkf4FE7o2fYrJacrsdo7uMgQQbghzer5JRjj2Qc2g3YMbp3BaQpOrkFRZAHj5 CQIrkBbRQtvuLC73ojeLuGTUD+eLRMpbByEENMM2kUXIOTQqKmtMcIdVF4vlWrFp wvi4TK4YFnybBUP0hX7MRI7qgI4EmfNupPv0aCRbu+mHsEkVA1mF0ELbUtCPpQ8w 6h7AnawR06KkXIqk5cidcpXEK+XMjwJlEseceMPlQxiVkbDZ68I7DeXe0qjDrizN x6uvBNvABkk9YHbKth7g99/I5h8BgCZl8jqVnyFKATifSh6rJ6oQEqXciz/tyxg0 XT5ZSyLDMeUsO1hfsVfYe56S5Tj9Af9yofSqK6ZGdq/QzXi1hW2mB4ZNsTJigMVx RYwg0RKOXXcVXY8l8uiewjV4TyjS2xzWjZbQgvMBG6bzNTRsqKi35MAO/n7YXpfx vWrIAiTbCPhN4HEZ2RsNtLSfPr7MJ7BtAaq6vNGhbRtQQjoYoeUlRDEC6yZK1yVA y5jy554dwDgquh491iEsHpZkejaAzsdQyp1pO6e6JK8UDWF3NHsG/1ul0bG+Bl66 8YFGvFrDlUn3wU16wMkWOO6iClzEHVhhfS2yFISIPyYKvJZM3cPxUE+jL3r/2uE3 LBPdgW+hLfR/NUnHwqf+ =QXul -----END PGP SIGNATURE----- --82I3+IH0IqGh5yIs-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: thierry.reding@avionic-design.de (Thierry Reding) Date: Fri, 8 Mar 2013 21:13:40 +0100 Subject: [PATCH 24/32] pci: PCIe driver for Marvell Armada 370/XP systems In-Reply-To: <20130308200245.GC29435@obsidianresearch.com> References: <20130307174955.GC20840@obsidianresearch.com> <20130307194830.GA1811@avionic-0098.mockup.avionic-design.de> <20130307200235.GB20695@obsidianresearch.com> <20130307204726.GB1811@avionic-0098.mockup.avionic-design.de> <51392B4D.9040404@gmail.com> <20130308071443.GA5772@avionic-0098.mockup.avionic-design.de> <20130308165228.GB4094@obsidianresearch.com> <20130308191227.GA6551@avionic-0098.mockup.avionic-design.de> <513A3F4F.2090501@firmworks.com> <20130308200245.GC29435@obsidianresearch.com> Message-ID: <20130308201339.GA26322@avionic-0098.mockup.avionic-design.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Mar 08, 2013 at 01:02:46PM -0700, Jason Gunthorpe wrote: > On Fri, Mar 08, 2013 at 09:43:11AM -1000, Mitch Bradley wrote: [...] > > 2) The "@0,0" and "@1,0" suffixes do not correspond to the reg values > > <0x0800 0 0 0 0> and <0x1000 0 0 0 0> using any rule that I know. > > @0,1,0 (bus,device,fn) could be more appropriate, but that is > cosmetic? The OF PCI specification is pretty strict about this as well. It says in section 2.2.1.3. that only the DD and DD,FF forms can appear in a device path. Thierry -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: not available URL: From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 24/32] pci: PCIe driver for Marvell Armada 370/XP systems Date: Fri, 8 Mar 2013 21:13:40 +0100 Message-ID: <20130308201339.GA26322@avionic-0098.mockup.avionic-design.de> References: <20130307174955.GC20840@obsidianresearch.com> <20130307194830.GA1811@avionic-0098.mockup.avionic-design.de> <20130307200235.GB20695@obsidianresearch.com> <20130307204726.GB1811@avionic-0098.mockup.avionic-design.de> <51392B4D.9040404@gmail.com> <20130308071443.GA5772@avionic-0098.mockup.avionic-design.de> <20130308165228.GB4094@obsidianresearch.com> <20130308191227.GA6551@avionic-0098.mockup.avionic-design.de> <513A3F4F.2090501@firmworks.com> <20130308200245.GC29435@obsidianresearch.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8965379991851869284==" Return-path: In-Reply-To: <20130308200245.GC29435-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Jason Gunthorpe Cc: Lior Amsalem , Andrew Lunn , Russell King - ARM Linux , Jason Cooper , Tawfik Bayouk , linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Eran Ben-Avi , Nadav Haklai , Maen Suleiman , Shadi Ammouri , Bjorn Helgaas , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org --===============8965379991851869284== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="82I3+IH0IqGh5yIs" Content-Disposition: inline --82I3+IH0IqGh5yIs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 08, 2013 at 01:02:46PM -0700, Jason Gunthorpe wrote: > On Fri, Mar 08, 2013 at 09:43:11AM -1000, Mitch Bradley wrote: [...] > > 2) The "@0,0" and "@1,0" suffixes do not correspond to the reg values > > <0x0800 0 0 0 0> and <0x1000 0 0 0 0> using any rule that I know. >=20 > @0,1,0 (bus,device,fn) could be more appropriate, but that is > cosmetic? The OF PCI specification is pretty strict about this as well. It says in section 2.2.1.3. that only the DD and DD,FF forms can appear in a device path. Thierry --82I3+IH0IqGh5yIs Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQIcBAEBAgAGBQJROkZzAAoJEN0jrNd/PrOhjOYQAK2XmBbA+p5sqjGBjfDOxGc/ Q3Amkf4FE7o2fYrJacrsdo7uMgQQbghzer5JRjj2Qc2g3YMbp3BaQpOrkFRZAHj5 CQIrkBbRQtvuLC73ojeLuGTUD+eLRMpbByEENMM2kUXIOTQqKmtMcIdVF4vlWrFp wvi4TK4YFnybBUP0hX7MRI7qgI4EmfNupPv0aCRbu+mHsEkVA1mF0ELbUtCPpQ8w 6h7AnawR06KkXIqk5cidcpXEK+XMjwJlEseceMPlQxiVkbDZ68I7DeXe0qjDrizN x6uvBNvABkk9YHbKth7g99/I5h8BgCZl8jqVnyFKATifSh6rJ6oQEqXciz/tyxg0 XT5ZSyLDMeUsO1hfsVfYe56S5Tj9Af9yofSqK6ZGdq/QzXi1hW2mB4ZNsTJigMVx RYwg0RKOXXcVXY8l8uiewjV4TyjS2xzWjZbQgvMBG6bzNTRsqKi35MAO/n7YXpfx vWrIAiTbCPhN4HEZ2RsNtLSfPr7MJ7BtAaq6vNGhbRtQQjoYoeUlRDEC6yZK1yVA y5jy554dwDgquh491iEsHpZkejaAzsdQyp1pO6e6JK8UDWF3NHsG/1ul0bG+Bl66 8YFGvFrDlUn3wU16wMkWOO6iClzEHVhhfS2yFISIPyYKvJZM3cPxUE+jL3r/2uE3 LBPdgW+hLfR/NUnHwqf+ =QXul -----END PGP SIGNATURE----- --82I3+IH0IqGh5yIs-- --===============8965379991851869284== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ devicetree-discuss mailing list devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org https://lists.ozlabs.org/listinfo/devicetree-discuss --===============8965379991851869284==--