From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Alexander Duyck <alexander.h.duyck@intel.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Subject: igb driver triggers BUILD_BUG_ON on s390
Date: Sat, 9 Mar 2013 11:00:04 +0100 [thread overview]
Message-ID: <20130309100004.GA3584@osiris> (raw)
git commit 74e238ead "igb: Support using build_skb in the case that
jumbo frames are disabled" added a BUILD_BUG_ON() to the igb drivers
which triggers on s390:
drivers/net/ethernet/intel/igb/igb_main.c:6231:2:
error: call to ‘__compiletime_assert_6235’ declared with attribute error:
BUILD_BUG_ON failed: SKB_WITH_OVERHEAD(IGB_RX_BUFSZ) <
(NET_SKB_PAD + NET_IP_ALIGN + IGB_TS_HDR_LEN + ETH_FRAME_LEN + ETH_FCS_LEN)
This happens mainly because s390 has an unusual large L1_CACHE_BYTES aka
SMP_CACHE_BYTES define with 256 Bytes.
The BUILD_BUG_ON(..) translates to (taken from .i file):
__cond = !(!(((2048) - (((sizeof(struct skb_shared_info)) + (256 - 1)) & ~(256 - 1))) < (32 + 2 + 16 + 1514 + 4)));
With sizeof(struct skb_shared_info) == 320 we end up with
BUILD_BUG_ON((2048 - 512 = 1536) < 1568)
One possible solution would be to simply disable the driver on s390.
Any opinions?
next reply other threads:[~2013-03-09 10:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-09 10:00 Heiko Carstens [this message]
2013-03-11 15:47 ` igb driver triggers BUILD_BUG_ON on s390 Alexander Duyck
2013-03-12 6:59 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130309100004.GA3584@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.