All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] mx6dl: Add initial support for Wandboard dual lite
Date: Sun, 10 Mar 2013 08:51:40 +0100	[thread overview]
Message-ID: <20130310075140.55FE4200642@gemini.denx.de> (raw)
In-Reply-To: <1362873704-23598-1-git-send-email-festevam@gmail.com>

Dear Fabio Estevam,

In message <1362873704-23598-1-git-send-email-festevam@gmail.com> you wrote:
> 
> Add initial support for Wandboard dual lite.
...

> Changes since v1:
> - Use get_ram_size
> - Remove ARP_TIMEOUT
> - Remove unneeded "1u"

Thanks.  I have still a question:

> +int dram_init(void)
> +{
> +	gd->ram_size = get_ram_size((void *)PHYS_SDRAM, PHYS_SDRAM_SIZE);
> +
> +	return 0;
> +}

I see this new code does not reference imx_ddr_size() any more.  If
it's so easy to switch to get_ram_size(), should we not then also
convert the existing MX53 and MX6 boards to using get_ram_size(), and
remove the then unneeded imx_ddr_size() code?

Or would there be any drawbacks?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
As far as the laws of mathematics refer to reality, they are not cer-
tain, and as far as they are certain, they do not refer  to  reality.
                                                   -- Albert Einstein

  reply	other threads:[~2013-03-10  7:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-10  0:01 [U-Boot] [PATCH v2] mx6dl: Add initial support for Wandboard dual lite Fabio Estevam
2013-03-10  7:51 ` Wolfgang Denk [this message]
2013-03-10 14:23   ` Eric Nelson
2013-03-10 15:42     ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130310075140.55FE4200642@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.