All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/4] directfb: fixing typo in variables
Date: Sun, 10 Mar 2013 11:25:27 +0100	[thread overview]
Message-ID: <20130310112527.4a82e689@skate> (raw)
In-Reply-To: <1362908858-6340-5-git-send-email-c.schoenert@gmail.com>

Dear Carsten Schoenert,

On Sun, 10 Mar 2013 10:47:38 +0100, Carsten Schoenert wrote:
> From: Carsten Schoenert <c.schoenert@gmail.com>
> 
> Signed-off-by: Carsten Schoenert <c.schoenert@gmail.com>
> ---
>  package/directfb/Config.in   |    4 ++--
>  package/directfb/directfb.mk |    4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/package/directfb/Config.in b/package/directfb/Config.in
> index 3d22e15..f5759db 100644
> --- a/package/directfb/Config.in
> +++ b/package/directfb/Config.in
> @@ -115,13 +115,13 @@ config BR2_PACKAGE_DIRECTFB_PNG
>  	default y
>  	select BR2_PACKAGE_LIBPNG
>  
> -config BR2_PACKAGE_DIRECTB_DITHER_RGB16
> +config BR2_PACKAGE_DIRECTFB_DITHER_RGB16
>  	bool "enable advanced dithering of RGB16 surfaces"
>  	help
>  	  Enable dithering when loading images to RGB16 surfaces.
>  	  This increases the data section by 64 KBytes.


This is good, but since you're renaming configuration options, you
should add something to the main Config.in.legacy:

config BR2_PACKAGE_DIRECTB_DITHER_RGB16
	bool "DirectFB RGB16 dithering option has been renamed"
	select BR2_PACKAGE_DIRECTFB_DITHER_RGB16
	select BR2_LEGACY

This way, users who will upgrade will be automatically notified of the
option rename.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2013-03-10 10:25 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-10  9:47 [Buildroot] [PATCH 0/0] Updating directfb and divine Carsten Schoenert
2013-03-10  9:47 ` [Buildroot] [PATCH 1/4] directfb: bumping version to 1.6.3 Carsten Schoenert
2013-03-10 10:32   ` Thomas Petazzoni
2013-03-10 12:34     ` Carsten Schoenert
2013-03-17 13:59       ` Carsten Schoenert
2013-03-21  6:56         ` Arnout Vandecappelle
2013-03-21 18:06           ` Carsten Schoenert
2013-03-21 19:13             ` Thomas Petazzoni
2013-04-02 21:56               ` Carsten Schoenert
2013-03-10 16:50     ` Carsten Schoenert
2013-03-10 17:25       ` Thomas Petazzoni
2013-03-10  9:47 ` [Buildroot] [PATCH 2/4] divine: " Carsten Schoenert
2013-03-10  9:47 ` [Buildroot] [PATCH 3/4] directfb: expanding the help strings Carsten Schoenert
2013-03-10 10:27   ` Thomas Petazzoni
2013-03-10 12:21     ` Carsten Schoenert
2013-03-10 13:13       ` Thomas Petazzoni
2013-03-10  9:47 ` [Buildroot] [PATCH 4/4] directfb: fixing typo in variables Carsten Schoenert
2013-03-10 10:25   ` Thomas Petazzoni [this message]
2013-03-10 12:23     ` Carsten Schoenert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130310112527.4a82e689@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.