All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Benoît Canet" <benoit.canet@irqsave.net>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [RFC V6 19/33] block: Add qcow2_dedup format and image creation code.
Date: Mon, 11 Mar 2013 16:20:03 +0100	[thread overview]
Message-ID: <20130311152003.GC3824@irqsave.net> (raw)
In-Reply-To: <20130207101621.GM1081@stefanha-thinkpad.redhat.com>

> > +    if (dedup) {
> > +        version = 3;
> > +    }
> 
> Lazy refcounts don't force the version.  It would be consistent to
> refrain from forcing the version too.

I don't understand. Aren't the incompatible features bits implying version = 3 ?
When compat=1.1 is set the code force version to 3.

Benoît

  parent reply	other threads:[~2013-03-11 15:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1360153926-9492-1-git-send-email-benoit@irqsave.net>
     [not found] ` <1360153926-9492-28-git-send-email-benoit@irqsave.net>
     [not found]   ` <20130208105746.GD7835@stefanha-thinkpad.redhat.com>
     [not found]     ` <20130227150028.GC4010@irqsave.net>
     [not found]       ` <20130228094139.GB12748@stefanha-thinkpad.redhat.com>
     [not found]         ` <20130228101434.GD2429@dhcp-200-207.str.redhat.com>
     [not found]           ` <20130228161418.GA4214@irqsave.net>
2013-03-01  8:59             ` [Qemu-devel] [RFC V6 27/33] qcow2: Adapt checking of QCOW_OFLAG_COPIED for dedup Kevin Wolf
2013-03-01  9:34               ` Stefan Hajnoczi
     [not found] ` <1360153926-9492-14-git-send-email-benoit@irqsave.net>
     [not found]   ` <20130207094814.GH1081@stefanha-thinkpad.redhat.com>
2013-03-11 12:59     ` [Qemu-devel] [RFC V6 13/33] qcow2: make the deduplication forget a cluster hash when a cluster is to dedupe Benoît Canet
     [not found] ` <1360153926-9492-20-git-send-email-benoit@irqsave.net>
     [not found]   ` <20130207101621.GM1081@stefanha-thinkpad.redhat.com>
2013-03-11 15:20     ` Benoît Canet [this message]
2013-03-12  9:33       ` [Qemu-devel] [RFC V6 19/33] block: Add qcow2_dedup format and image creation code Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130311152003.GC3824@irqsave.net \
    --to=benoit.canet@irqsave.net \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.