From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] mac80211: fixes for virtual monitor add/remove on suspend
Date: Mon, 11 Mar 2013 18:07:13 +0100 [thread overview]
Message-ID: <20130311170712.GB1430@redhat.com> (raw)
In-Reply-To: <1363021279-9809-2-git-send-email-sgruszka@redhat.com>
On Mon, Mar 11, 2013 at 06:01:19PM +0100, Stanislaw Gruszka wrote:
> Change suspend/resume and add/remove virtual monitor code (called at
> ieee80211_do_stop) to avoid calling drv callback while we are suspended.
[snip]
> - if (sdata && ieee80211_sdata_running(sdata))
> - ieee80211_assign_chanctx(local, sdata);
> + if (sdata) {
> + res = ieee80211_vif_use_channel(sdata, &local->monitor_chandef,
> + IEEE80211_CHANCTX_EXCLUSIVE);
> + if (WARN_ON(res)) {
> + drv_remove_interface(local, sdata);
> + rcu_assign_pointer(local->monitor_sdata, NULL);
> + synchronize_net();
> + kfree(sdata);
> + }
Hmm, this probably shouldn't be changed for hw restart case.
Stanislaw
next prev parent reply other threads:[~2013-03-11 17:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 17:01 [PATCH 1/2] mac80211: some fixes for ieee80211_do_stop while suspend Stanislaw Gruszka
2013-03-11 17:01 ` [PATCH 2/2] mac80211: fixes for virtual monitor add/remove on suspend Stanislaw Gruszka
2013-03-11 17:07 ` Stanislaw Gruszka [this message]
2013-03-12 10:32 ` [PATCH 2/2 v2] " Stanislaw Gruszka
2013-03-15 15:44 ` [PATCH 1/2] mac80211: some fixes for ieee80211_do_stop while suspend Johannes Berg
2013-03-18 9:30 ` Stanislaw Gruszka
2013-03-22 21:14 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130311170712.GB1430@redhat.com \
--to=sgruszka@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.