From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Michail Kurachkin <michail.kurachkin@promwad.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Kuten Ivan <Ivan.Kuten@promwad.com>,
"benavi@marvell.com" <benavi@marvell.com>,
Palstsiuk Viktar <Viktar.Palstsiuk@promwad.com>,
Dmitriy Gorokh <dmitriy.gorokh@promwad.com>,
Oliver Neukum <oneukum@suse.de>, Ryan Mallon <rmallon@gmail.com>
Subject: Re: [PATCH v2 01/11] staging: Initial commit of TDM core
Date: Mon, 11 Mar 2013 10:17:26 -0700 [thread overview]
Message-ID: <20130311171726.GA25166@kroah.com> (raw)
In-Reply-To: <563f0589ba8c56bd194938f8bff80a06b15f9418.1362133319.git.michail.kurachkin@promwad.com>
On Fri, Mar 01, 2013 at 01:50:37PM +0300, Michail Kurachkin wrote:
> From: Michail Kurochkin <michail.kurachkin@promwad.com>
>
> Signed-off-by: Michail Kurochkin <michail.kurachkin@promwad.com>
> ---
> drivers/staging/Kconfig | 4 +
> drivers/staging/Makefile | 4 +-
> drivers/staging/tdm/Kconfig | 38 ++
> drivers/staging/tdm/Makefile | 19 +
> drivers/staging/tdm/tdm.h | 292 ++++++++++++++
> drivers/staging/tdm/tdm_core.c | 826 ++++++++++++++++++++++++++++++++++++++++
> 6 files changed, 1182 insertions(+), 1 deletions(-)
> create mode 100644 drivers/staging/tdm/Kconfig
> create mode 100644 drivers/staging/tdm/Makefile
> create mode 100644 drivers/staging/tdm/tdm.h
> create mode 100644 drivers/staging/tdm/tdm_core.c
>
> diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig
> index 329bdb4..9bba991 100644
> --- a/drivers/staging/Kconfig
> +++ b/drivers/staging/Kconfig
> @@ -26,6 +26,10 @@ if STAGING
>
> source "drivers/staging/et131x/Kconfig"
>
> +source "drivers/staging/si3226x/Kconfig"
> +
> +source "drivers/staging/tdm/Kconfig"
You just broke the build with this patch :(
Please, EVERY patch has to be buildable at every step of the way. I
can't take patches that break the build, especially ones that do so in
such obvious ways.
Please resend this whole series, fixing this problem, and changing the
Subject: lines like I asked for last time as well.
thanks,
greg k-h
next prev parent reply other threads:[~2013-03-11 17:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-27 16:22 [PATCH 0/9] Support of TDM bus, TDM driver for Marvell Kirkwood and SLIC driver for Silabs Si3226x Michail Kurachkin
2013-03-01 10:42 ` [PATCH v2 00/11] staging: " Michail Kurachkin
2013-03-01 10:50 ` [PATCH v2 01/11] staging: Initial commit of TDM core Michail Kurachkin
2013-03-01 22:54 ` Ryan Mallon
2013-03-11 17:17 ` Greg Kroah-Hartman [this message]
2013-03-01 10:52 ` [PATCH v2 02/11] staging: Initial commit of Kirkwood TDM driver Michail Kurachkin
2013-03-01 23:54 ` Ryan Mallon
2013-03-01 10:54 ` [PATCH v2 03/11] staging: Initial commit of SLIC si3226x driver Michail Kurachkin
2013-03-01 10:56 ` [PATCH v2 04/11] staging: added TODO file for si3226x Michail Kurachkin
2013-03-01 10:57 ` [PATCH v2 05/11] staging: refactoring request/free voice channels Michail Kurachkin
2013-03-02 22:56 ` Ryan Mallon
2013-03-01 10:58 ` [PATCH v2 06/11] staging: remove device_attribute Michail Kurachkin
2013-03-01 11:00 ` [PATCH v2 07/11] staging: added issues description in TODO file Michail Kurachkin
2013-03-01 11:00 ` [PATCH v2 08/11] staging: removing of buffer filling flag and also reverting old buffer related fix which is not really effective Michail Kurachkin
2013-03-01 11:02 ` [PATCH v2 09/11] staging: fixed e-mail address Michail Kurachkin
2013-03-01 11:03 ` [PATCH v2 10/11] staging: add issuses in TODO Michail Kurachkin
2013-03-01 11:04 ` [PATCH v2 11/11] " Michail Kurachkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130311171726.GA25166@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Ivan.Kuten@promwad.com \
--cc=Viktar.Palstsiuk@promwad.com \
--cc=benavi@marvell.com \
--cc=dmitriy.gorokh@promwad.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michail.kurachkin@promwad.com \
--cc=oneukum@suse.de \
--cc=rmallon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.