Re: [PATCH] signal: always clear sa_restorer on execve

[Oleg Nesterov <oleg@redhat.com>]

On 03/11, Kees Cook wrote:
> On Mon, Mar 11, 2013 at 12:28 PM, Oleg Nesterov <oleg@redhat.com> wrote:
> > On 03/11, Kees Cook wrote:
> >>
> >> When the new signal handlers are set up for a fork, the location of
> >> sa_restorer is not cleared, leaking a parent process's address space
> >> location to children. This allows for a potential bypass of the parent's
> >> ASLR by examining the sa_restorer value returned when calling sigaction().
> >
> > I don't understand.
> >
> > fork() should not change restorer/etc, and the child has the same address
> > space anyway. There is no any leak and the patch can't make any difference
> > in this case because flush_signal_handlers() is not called by fork().
>
> I probably failed to explain this correctly. From the perspective of
> what should be considered "secret", it only matters across the exec,
> not the fork (since the VMAs haven't changed until the exec).

Exactly. So may be you should update the changelog? It really looks
as if the parent should "hide" something from the forked child.

> But the
> info leak is easy to see, and this patch fixes it. As you say, since
> other things were reset, so should sa_restorer.

Yes, I didn't argue with the patch itself.

Oleg.