From: Daniel Vetter <daniel@ffwll.ch>
To: "Zhang, Xiong Y" <xiong.y.zhang@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: ignore hotplug event across suspend
Date: Tue, 12 Mar 2013 00:42:43 +0100 [thread overview]
Message-ID: <20130311234243.GG3872@bremse> (raw)
In-Reply-To: <8082FF9BCB2B054996454E47167FF4ECCA8049@SHSMSX102.ccr.corp.intel.com>
On Mon, Mar 11, 2013 at 03:54:11AM +0000, Zhang, Xiong Y wrote:
> when system enter suspend, hibernate and poweroff state, it will
> disable modeset firstly, then disable irq, but some system generate
> hotplug event between disable modeset and disable irq, this will
> result in S3, S4 failure. So this hotplug event should be ignored.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=61508
> Signed-off-by: Xiong Zhang <xiong.y.zhang@intel.com>
Should be fixed with
commit b8efb17b3d687695b81485f606fc4e6c35a50f9a
Author: Zhang Rui <rui.zhang@intel.com>
Date: Tue Feb 5 15:41:53 2013 +0800
i915: ignore lid open event when resuming
Cheers, Daniel
> ---
> drivers/gpu/drm/i915/i915_irq.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index 2139714..68cc7a7 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -290,6 +290,12 @@ static void i915_hotplug_work_func(struct work_struct *work)
> struct drm_device *dev = dev_priv->dev;
> struct drm_mode_config *mode_config = &dev->mode_config;
> struct intel_encoder *encoder;
> +
> + /* some system generate hotplug envent when system enter sleep state.
> + * it should be ignored.
> + */
> + if (dev_priv->mm.suspended)
> + return;
>
> /* HPD irq before everything is fully set up. */
> if (!dev_priv->enable_hotplug_processing)
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-03-11 23:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 3:54 [PATCH] drm/i915: ignore hotplug event across suspend Zhang, Xiong Y
2013-03-11 23:42 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130311234243.GG3872@bremse \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=xiong.y.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.