From: Luis Henriques <luis.henriques@canonical.com>
To: Colin Cross <ccross@google.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
"Tu, Xiaobing" <xiaobing.tu@intel.com>,
"davej@redhat.com" <davej@redhat.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"mingo@elte.hu" <mingo@elte.hu>,
"rusty@rustcorp.com.au" <rusty@rustcorp.com.au>,
"a.p.zijlstra@chello.nl" <a.p.zijlstra@chello.nl>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"Tang, Guifang" <guifang.tang@intel.com>,
stable@vger.kernel.org
Subject: Re: Fix memory leak in cpufreq stats.
Date: Tue, 12 Mar 2013 12:14:58 +0000 [thread overview]
Message-ID: <20130312121458.GC3222@hercules> (raw)
In-Reply-To: <CAMbhsRTi8-41em4+-7NpLwXFpbGcy3Vsib5ees_OWm5JGmOVDw@mail.gmail.com>
On Mon, Mar 11, 2013 at 06:23:27PM -0700, Colin Cross wrote:
> On Mon, Oct 15, 2012 at 1:30 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> > On Monday 15 of October 2012 02:48:28 Tu, Xiaobing wrote:
> >>
> >> Fix memory leak in cpufreq stats.
> >>
> >> When system enter sleep, non-boot CPUs will be disable.
> >> Cpufreq stats sysfs is created when the CPU is up, but it is not freed when
> >> the CPU going down. This will cause memory leak.
> >> signed-off-by: xiaobing tu <xiaobing.tu@intel.com>
> >> signed-off-by: guifang tang <guifang.tang@intel.com>
> >
> > I will push this patch for v3.7 in the -rc3 time frame if no one objects.
> >
> > Thanks,
> > Rafael
> >
> >
> >> diff --git a/drivers/cpufreq/cpufreq_stats.c b/drivers/cpufreq/cpufreq_stats.c
> >> index b40ee14..3998316 100644
> >> --- a/drivers/cpufreq/cpufreq_stats.c
> >> +++ b/drivers/cpufreq/cpufreq_stats.c
> >> @@ -328,6 +328,7 @@ static int __cpuinit cpufreq_stat_cpu_callback(struct notifier_block *nfb,
> >> cpufreq_update_policy(cpu);
> >> break;
> >> case CPU_DOWN_PREPARE:
> >> + case CPU_DOWN_PREPARE_FROZEN:
> >> cpufreq_stats_free_sysfs(cpu);
> >> break;
> >> case CPU_DEAD:
> >>
> >> Br
> >> XiaoBing Tu
> >> PSI@System Integration Shanghai
>
> This patch, commited as e37736777254ce1abc85493a5cacbefe5983b896 since
> v3.7, should also have gone to stable. It should apply all the way
> back to 3.0.
Thanks, I'm queuing it for the 3.5 kernel.
Cheers,
--
Luis
next prev parent reply other threads:[~2013-03-12 12:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-15 2:48 Fix memory leak in cpufreq stats Tu, Xiaobing
2012-10-15 20:30 ` Rafael J. Wysocki
2013-03-12 1:23 ` Colin Cross
2013-03-12 12:14 ` Luis Henriques [this message]
2013-03-17 5:13 ` Ben Hutchings
-- strict thread matches above, loose matches on Subject: below --
2012-10-15 7:04 Tu, Xiaobing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130312121458.GC3222@hercules \
--to=luis.henriques@canonical.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=ccross@google.com \
--cc=davej@redhat.com \
--cc=guifang.tang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rjw@sisk.pl \
--cc=rostedt@goodmis.org \
--cc=rusty@rustcorp.com.au \
--cc=stable@vger.kernel.org \
--cc=xiaobing.tu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.