All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Aaron Carroll <aaronc@cse.unsw.edu.au>
Cc: fio@vger.kernel.org
Subject: Re: [PATCH] Android: add ioprio support
Date: Tue, 12 Mar 2013 13:15:09 +0100	[thread overview]
Message-ID: <20130312121508.GN25165@kernel.dk> (raw)
In-Reply-To: <513EB3E5.7020209@cse.unsw.edu.au>

On Tue, Mar 12 2013, Aaron Carroll wrote:
> Also fix a build warning due to unused variable in some configs.

I applied the ioprio part, is the other bit against an older series?

> diff --git a/engines/net.c b/engines/net.c
> index 624ff15..abb8412 100644
> --- a/engines/net.c
> +++ b/engines/net.c
> @@ -490,6 +490,9 @@ static int fio_netio_connect(struct thread_data *td, struct fio_file *f)
>  			return 1;
>  		}
>  	}
> +#else
> +	/* avoid warnings */
> +	(void)optval;
>  #endif
>  
>  	if (o->proto == FIO_TYPE_UDP)
> @@ -553,6 +556,9 @@ static int fio_netio_accept(struct thread_data *td, struct fio_file *f)
>  			return 1;
>  		}
>  	}
> +#else
> +	/* avoid warnings */
> +	(void)optval;
>  #endif
>  
>  	reset_all_stats(td);

optval is only inside the scope of the ifdef. This was changed with
commit 6264c7a8 as of Feb 28th.

-- 
Jens Axboe


  reply	other threads:[~2013-03-12 12:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-12  4:49 [PATCH] Android: add ioprio support Aaron Carroll
2013-03-12 12:15 ` Jens Axboe [this message]
2013-03-13  1:12   ` Aaron Carroll

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130312121508.GN25165@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=aaronc@cse.unsw.edu.au \
    --cc=fio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.