From: Greg KH <gregkh@linuxfoundation.org>
To: Mayuresh Kulkarni <mkulkarni@nvidia.com>
Cc: linux-pm@vger.kernel.org, len.brown@intel.com, pavel@ucw.cz,
rjw@sisk.pl, pdeschrijver@nvidia.com
Subject: Re: [PATCH] PM/domains: add delayed power off capability
Date: Tue, 12 Mar 2013 06:49:13 -0700 [thread overview]
Message-ID: <20130312134913.GD3514@kroah.com> (raw)
In-Reply-To: <1363078159-17571-1-git-send-email-mkulkarni@nvidia.com>
On Tue, Mar 12, 2013 at 02:19:19PM +0530, Mayuresh Kulkarni wrote:
> - this commit adds a capability to delay the powering off
> of the domain
Why?
> - callers can use pm_genpd_set_poweroff_delay to set the
> power off delay for a domain
Why?
> - it expects the delay in milli-seconds
Why?
> - it also adds a pm_notifier per pm domain which cancels
> the delayed power off work when system suspend is invoked
Why?
Come on, please tell us why something is needed and not what it does in
a changelog comment.
> Signed-off-by: Mayuresh Kulkarni <mkulkarni@nvidia.com>
> ---
>
> - The idea here is to avoid the powering off of a domain if use cases causes
> it to turn on within specific time in coming future
What use case?
> - This seems to save power and better response by avoiding context save/restore
> which are heavy operations in most of the cases
Now these four lines are bit better, why are you hiding it down here?
Who is going to use this code? Where is those callers? We don't add
new infrastructure without in-kernel users, unless there is a very good
reason.
greg k-h
next prev parent reply other threads:[~2013-03-12 13:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 8:49 [PATCH] PM/domains: add delayed power off capability Mayuresh Kulkarni
2013-03-12 13:49 ` Greg KH [this message]
2013-03-12 14:56 ` Mayuresh Kulkarni
2013-03-12 15:19 ` Greg KH
2013-03-12 15:24 ` Peter De Schrijver
2013-03-12 15:44 ` Greg KH
2013-03-13 19:27 ` Kevin Hilman
2013-03-14 8:59 ` Peter De Schrijver
2013-03-14 14:12 ` Mayuresh Kulkarni
2013-03-15 18:04 ` Kevin Hilman
2013-03-18 10:07 ` Peter De Schrijver
2013-03-22 16:58 ` Kevin Hilman
2013-03-14 14:59 ` Alan Stern
-- strict thread matches above, loose matches on Subject: below --
2013-03-11 15:50 Mayuresh Kulkarni
[not found] ` <1363017028-16164-1-git-send-email-mkulkarni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-11 17:47 ` Stephen Warren
2013-03-12 14:29 ` Peter De Schrijver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130312134913.GD3514@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=len.brown@intel.com \
--cc=linux-pm@vger.kernel.org \
--cc=mkulkarni@nvidia.com \
--cc=pavel@ucw.cz \
--cc=pdeschrijver@nvidia.com \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.