From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH] PM/domains: add delayed power off capability Date: Tue, 12 Mar 2013 08:44:10 -0700 Message-ID: <20130312154410.GD18852@kroah.com> References: <1363078159-17571-1-git-send-email-mkulkarni@nvidia.com> <20130312134913.GD3514@kroah.com> <513F4208.4040207@nvidia.com> <20130312151901.GA18438@kroah.com> <20130312152450.GB18519@tbergstrom-lnx.Nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pb0-f51.google.com ([209.85.160.51]:64273 "EHLO mail-pb0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932935Ab3CLPnZ (ORCPT ); Tue, 12 Mar 2013 11:43:25 -0400 Received: by mail-pb0-f51.google.com with SMTP id un15so5133153pbc.10 for ; Tue, 12 Mar 2013 08:43:24 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130312152450.GB18519@tbergstrom-lnx.Nvidia.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Peter De Schrijver Cc: Mayuresh Kulkarni , "linux-pm@vger.kernel.org" , "len.brown@intel.com" , "pavel@ucw.cz" , "rjw@sisk.pl" On Tue, Mar 12, 2013 at 05:24:50PM +0200, Peter De Schrijver wrote: > On Tue, Mar 12, 2013 at 04:19:01PM +0100, Greg KH wrote: > > On Tue, Mar 12, 2013 at 08:26:08PM +0530, Mayuresh Kulkarni wrote: > > > On Tuesday 12 March 2013 07:19 PM, Greg KH wrote: > > > >On Tue, Mar 12, 2013 at 02:19:19PM +0530, Mayuresh Kulkarni wrote: > > > >>- this commit adds a capability to delay the powering off > > > >>of the domain > > > > > > > >Why? > > > > > > > > > > - As I mentioned below (sorry for mentioning below rather than at > > > start), powering off a domain means the context save needs to be > > > done && it needs to be restored during power on. > > > > > > > > All of this should be in the changelog section of the patch, please, > > when you resend this, add it there. > > > > > - The downstream kernel has a graphics-host (host1x) driver which > > > has a home grown power management framework called ACM > > > (auto-clock-management). We implement both delayed clock and power > > > partition off functionality in it. > > > > We should wait for this driver to be submitted and accepted before > > we can add these new api hooks. When is that going to happen? > > > > The basic host1x driver has been under review and rework for quite some > time now. See http://www.spinics.net/lists/linux-tegra/msg10128.html > for the latest version. The PM features are still missing though, but > will be submitted once the basic version is accepted. That sounds good to me, thanks. greg k-h