From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH 2 of 5] tools/xc: document printf calls in xc_restore Date: Tue, 12 Mar 2013 17:47:10 +0100 Message-ID: <20130312164710.GA26446@aepfle.de> References: <49b90990442aca9523ac.1362588508@probook.site> <1363106179.32410.45.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1363106179.32410.45.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On Tue, Mar 12, Ian Campbell wrote: > On Wed, 2013-03-06 at 16:48 +0000, Olaf Hering wrote: > > # HG changeset patch > > # User Olaf Hering > > # Date 1362584522 -3600 > > # Node ID 49b90990442aca9523acbf889cbb517ea44d20b4 > > # Parent e5ae0e680b5c64d7808bb6a68ea47ef1bbf68a51 > > tools/xc: document printf calls in xc_restore > > > > Signed-off-by: Olaf Hering > > > > diff -r e5ae0e680b5c -r 49b90990442a tools/xcutils/xc_restore.c > > --- a/tools/xcutils/xc_restore.c > > +++ b/tools/xcutils/xc_restore.c > > @@ -56,6 +56,7 @@ main(int argc, char **argv) > > > > if ( ret == 0 ) > > { > > + /* xend expects this output, part of protocol */ > > xc_restore is effectively part of xend (just factored into its own > process), no one else uses this stuff. > > What I guess I'm saying is that we can take everything which this file > does as being desired by xend... The purpose is more to not convert them to DPRINTF or something, like I did it once until I realized that these printf calls should stay as is. Olaf