From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Graeme Gregory <gg@slimlogic.co.uk>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: palmas: Use of_property_read_bool to read "ti,warm-reset" DT property
Date: Tue, 12 Mar 2013 18:16:15 +0000 [thread overview]
Message-ID: <20130312181615.GB19942@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1363102819.3160.1.camel@phoenix>
[-- Attachment #1: Type: text/plain, Size: 337 bytes --]
On Tue, Mar 12, 2013 at 11:40:19PM +0800, Axel Lin wrote:
> It does not make sense to assign return value of of_property_read_u32() to
> pdata->reg_init[idx]->warm_reset. Use of_property_read_bool() to read
> "ti,warm-reset" DT property instead which will return correct setting
> for pdata->reg_init[idx]->warm_reset.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-03-12 18:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 15:40 [PATCH] regulator: palmas: Use of_property_read_bool to read "ti,warm-reset" DT property Axel Lin
2013-03-12 16:10 ` Graeme Gregory
2013-03-12 18:16 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130312181615.GB19942@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=axel.lin@ingics.com \
--cc=gg@slimlogic.co.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.