From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 07/10] ASoC: phycore-ac97: Add DT support Date: Tue, 12 Mar 2013 18:59:22 +0000 Message-ID: <20130312185921.GX19942@opensource.wolfsonmicro.com> References: <1362940391-8338-1-git-send-email-mpa@pengutronix.de> <1362940391-8338-8-git-send-email-mpa@pengutronix.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4198827805944969795==" Return-path: In-Reply-To: <1362940391-8338-8-git-send-email-mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Markus Pargmann Cc: Fabio Estevam , alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Liam Girdwood , Sascha Hauer , Timur Tabi , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: alsa-devel@alsa-project.org --===============4198827805944969795== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="4PR/+zdSfVlxyWed" Content-Disposition: inline --4PR/+zdSfVlxyWed Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Mar 10, 2013 at 07:33:08PM +0100, Markus Pargmann wrote: > Add devicetree support for this audio soc fabric driver. >=20 > Signed-off-by: Markus Pargmann > --- > sound/soc/fsl/phycore-ac97.c | 148 ++++++++++++++++++++++++++++++++++++-= ------ > 1 file changed, 125 insertions(+), 23 deletions(-) A binding document is mandatory for new bindings. > +#ifdef CONFIG_MACH_IMX27_DT > + .cpu_dai_name =3D "10010000.ssi", > + .platform_name =3D "imx-fiq-pcm-audio", > +#else This looks wrong, at least the CPU DAI name should be being looked up via the DT. > +static const struct of_device_id imx_phycore_ac97_of_dev_id[] =3D { > + { > + .compatible =3D "phytec,imx27-pca100-ac97", > + .data =3D (void *)MX27_PCA100, > + }, { > + .compatible =3D "phytec,imx27-pcm043-ac97", > + .data =3D (void *)MX27_PCM043 > + }, { > + /* sentinel */ > + } > +}; > +MODULE_DEVICE_TABLE(of, imx_phycore_ac97_of_dev_id); It seems like we ought to be able to describe the properties of the boards in this class rather than just enumerating the boards. What are the differences? > MODULE_AUTHOR("Sascha Hauer "); > -MODULE_DESCRIPTION("PhyCORE ALSA SoC driver"); > +MODULE_DESCRIPTION(DRV_NAME ": PhyCORE ALSA SoC fabric driver"); Please don't make up terms like "fabric driver". --4PR/+zdSfVlxyWed Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBAgAGBQJRP3sDAAoJELSic+t+oim9wMwP/RoGVToEOungyy+z0NHpmXAQ lfElfdmodx3Qz2lj9cgfWtJduBdDucgqtMb67RvbVc3ILn8Urz6ofXTwSuyeoN0N lY584ERPAnvof+J2SG3qbeQyEFn6GuHCW2PJwuepiAQMMPfyZFbjUoNhScmoGiqw 5z0kzjvTDEQmSQQycBqs8Zc+uEkwZqulc/aMaBd2UATFu+8ZkJZtyQdxT9/r5G8p rB0zENwGrKJyiStLNdc/lW4BcAw4eTfyiKB6TMMEduJjUhVXg5KqheTDfreER+n6 de8o+lBiQ6U304QilfPqV2+YSKGqyVNVszERzNNoUQ12fhIJ9HNp24RVa+kqNMIN k+jfC/HO3kWruddm91yd8jw46N+HSnv4waeLt2ChxPxnSxh6BPEkD54LWYau0SO3 LuJ8W0PUN+7LGkNbBayA+piziRxW74mpcSN6UQRLEU7RCgT9sVKCtkHNYmB5NzlC Xu/XgDrhu1gw+Kk8aYMn8EWKA9RttuuUiFZFASKbnkSYVkRT6nXZORQgXhuBr1k+ rgT2572QI6haGWirQCBZptVjkq1ecIaowmuoJPt+CgaF2u0gQ5NVnZs3smlmO4EO 60CboHfUv0coBDqcbvqOMdHcYIp84YamBsK1y/5YCW3HE2mTPwj0ZkZzD5DdQmTW tPJgTw7MsD7ikicVUHu1 =2kNB -----END PGP SIGNATURE----- --4PR/+zdSfVlxyWed-- --===============4198827805944969795== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ devicetree-discuss mailing list devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org https://lists.ozlabs.org/listinfo/devicetree-discuss --===============4198827805944969795==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: broonie@opensource.wolfsonmicro.com (Mark Brown) Date: Tue, 12 Mar 2013 18:59:22 +0000 Subject: [PATCH 07/10] ASoC: phycore-ac97: Add DT support In-Reply-To: <1362940391-8338-8-git-send-email-mpa@pengutronix.de> References: <1362940391-8338-1-git-send-email-mpa@pengutronix.de> <1362940391-8338-8-git-send-email-mpa@pengutronix.de> Message-ID: <20130312185921.GX19942@opensource.wolfsonmicro.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sun, Mar 10, 2013 at 07:33:08PM +0100, Markus Pargmann wrote: > Add devicetree support for this audio soc fabric driver. > > Signed-off-by: Markus Pargmann > --- > sound/soc/fsl/phycore-ac97.c | 148 ++++++++++++++++++++++++++++++++++++------- > 1 file changed, 125 insertions(+), 23 deletions(-) A binding document is mandatory for new bindings. > +#ifdef CONFIG_MACH_IMX27_DT > + .cpu_dai_name = "10010000.ssi", > + .platform_name = "imx-fiq-pcm-audio", > +#else This looks wrong, at least the CPU DAI name should be being looked up via the DT. > +static const struct of_device_id imx_phycore_ac97_of_dev_id[] = { > + { > + .compatible = "phytec,imx27-pca100-ac97", > + .data = (void *)MX27_PCA100, > + }, { > + .compatible = "phytec,imx27-pcm043-ac97", > + .data = (void *)MX27_PCM043 > + }, { > + /* sentinel */ > + } > +}; > +MODULE_DEVICE_TABLE(of, imx_phycore_ac97_of_dev_id); It seems like we ought to be able to describe the properties of the boards in this class rather than just enumerating the boards. What are the differences? > MODULE_AUTHOR("Sascha Hauer "); > -MODULE_DESCRIPTION("PhyCORE ALSA SoC driver"); > +MODULE_DESCRIPTION(DRV_NAME ": PhyCORE ALSA SoC fabric driver"); Please don't make up terms like "fabric driver". -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: