All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Seebach <peter.seebach@windriver.com>
To: Paul Eggleton <paul.eggleton@linux.intel.com>
Cc: Chris Larson <clarson@kergoth.com>, bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH] data_smart: Add _remove operator
Date: Wed, 13 Mar 2013 13:28:57 -0500	[thread overview]
Message-ID: <20130313132857.505e0f96@e6410-2> (raw)
In-Reply-To: <2406047.qZssv5BGAg@helios>

On Sun, 10 Mar 2013 20:39:07 +0000
Paul Eggleton <paul.eggleton@linux.intel.com> wrote:

> I can't recall if we've discussed this before, but shouldn't we be looking at 
> introducing some understanding of list type variables into BitBake itself? If 
> BitBake knew the variable was a list it would be possible to have language 
> elements that understood how to behave in this situation.

I rather like this. I would like to have _remove, and it may even make sense
to adopt _remove in the short term, but really I think most of the things
where we're using append/remove should probably be lists, which would also
eliminate the entire category of bugs in which it is unclear whether or not
to add a space.

Rough thoughts about implementation: Listness could be a flag.

LIST[list] = " "
LIST = "blah blah blah"
# Oh, hey, what if...
PATH[list] = ":"

or as shorthand:

LIST = [blah blah blah]

If this is done, the behavior of append/prepend is slightly altered (to
always ensure separators are added when needed), and then we could more
easily handle the remove case, too.

That said: I'd rather see a plain _remove go in than wait on a larger and
fancier design.

-s
-- 
Listen, get this.  Nobody with a good compiler needs to be justified.



  reply	other threads:[~2013-03-13 18:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-09 12:47 [PATCH] data_smart: Add _remove operator Richard Purdie
2013-03-09 23:20 ` Chris Larson
2013-03-10 20:39   ` Paul Eggleton
2013-03-13 18:28     ` Peter Seebach [this message]
2013-03-13 23:04       ` Chris Larson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130313132857.505e0f96@e6410-2 \
    --to=peter.seebach@windriver.com \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=clarson@kergoth.com \
    --cc=paul.eggleton@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.