From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH 4/6] xc: XENMEM_claim_pages outstanding claims value Date: Wed, 13 Mar 2013 10:57:34 -0400 Message-ID: <20130313145734.GH25782@phenom.dumpdata.com> References: <1363011652-25949-1-git-send-email-konrad.wilk@oracle.com> <1363011652-25949-5-git-send-email-konrad.wilk@oracle.com> <1363171408.32410.141.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1363171408.32410.141.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: "Keir (Xen.org)" , Dan Magenheimer , "xen-devel@lists.xensource.com" , "Tim (Xen.org)" , "konrad@kernel.org" List-Id: xen-devel@lists.xenproject.org On Wed, Mar 13, 2013 at 10:43:28AM +0000, Ian Campbell wrote: > On Mon, 2013-03-11 at 14:20 +0000, Konrad Rzeszutek Wilk wrote: > > From: Dan Magenheimer > > > > This is patch provides the value of claimed pages but > > not yet accounted for in a domain (outstanding). This is a > > total global value that influences the hypervisors' MM system. > > This value - when the guest has finally been created and is > > running - ends up having the value zero. But during the > > memory populate calls the contents of this value will > > decrease. > > I think you are trying to say that it jumps to some large value when a > claim is made, and then reduces as the domain's memory is populated and > eventually reaches zero (either through allocations or the claim being > released)? Yes. That is what I was trying to say :-) > > > > > Signed-off-by: Dan Magenheimer > > [v2: s/unclaimed_pages/outstanding_pages/ per Tim's suggestion] > > Signed-off-by: Konrad Rzeszutek Wilk > > --- > > tools/libxc/xc_domain.c | 1 + > > tools/libxc/xenctrl.h | 1 + > > 2 files changed, 2 insertions(+) > > > > diff --git a/tools/libxc/xc_domain.c b/tools/libxc/xc_domain.c > > index b8a345c..ab6dde5 100644 > > --- a/tools/libxc/xc_domain.c > > +++ b/tools/libxc/xc_domain.c > > @@ -234,6 +234,7 @@ int xc_domain_getinfo(xc_interface *xch, > > > > info->ssidref = domctl.u.getdomaininfo.ssidref; > > info->nr_pages = domctl.u.getdomaininfo.tot_pages; > > + info->nr_outstanding_pages = domctl.u.getdomaininfo.outstanding_pages; > > info->nr_shared_pages = domctl.u.getdomaininfo.shr_pages; > > info->nr_paged_pages = domctl.u.getdomaininfo.paged_pages; > > info->max_memkb = domctl.u.getdomaininfo.max_pages << (PAGE_SHIFT-10); > > diff --git a/tools/libxc/xenctrl.h b/tools/libxc/xenctrl.h > > index e695456..2a4d4df 100644 > > --- a/tools/libxc/xenctrl.h > > +++ b/tools/libxc/xenctrl.h > > @@ -364,6 +364,7 @@ typedef struct xc_dominfo { > > hvm:1, debugged:1; > > unsigned int shutdown_reason; /* only meaningful if shutdown==1 */ > > unsigned long nr_pages; /* current number, not maximum */ > > + unsigned long nr_outstanding_pages; > > unsigned long nr_shared_pages; > > unsigned long nr_paged_pages; > > unsigned long shared_info_frame; > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel >