From: Jens Axboe <axboe@kernel.dk>
To: Aaron Carroll <aaronc@cse.unsw.edu.au>
Cc: fio@vger.kernel.org
Subject: Re: [PATCH/RFC] Improve cross-compile support
Date: Wed, 13 Mar 2013 15:59:30 +0100 [thread overview]
Message-ID: <20130313145930.GJ25165@kernel.dk> (raw)
In-Reply-To: <CAKCZDgn5ds9-Fmn6pLW4Y7eCpeJr2C5gks1jKgCK3J-wNtXoeQ@mail.gmail.com>
On Wed, Mar 13 2013, Aaron Carroll wrote:
> A first attempt at making cross-compile viable is attached.
>
> Specifically we:
> - Propagate the target OS from configure to Makefile so we dont need uname
> - Allow CROSS_COMPILE for toolchain prefix, which is common (e.g. Linux)
> - Allow wordsize and bigendian to be set statically. These are
> usually determined by executing a test program, which obviously
> doesn't work for cross compiles.
> - Make the Android config dynamic (but set wordsize/bigendian)
>
> Now the wordsize/bigendian handling is not ideal but I can't think of
> a better approach right now.
>
> Also I've changed the #includes in the socklet_t check. sys/socket.h
> appears to be the right thing, but please check.
>
> Compile tested on Linux/i386 native, Linux/i386 to Android cross
> compile, and OS X native.
Looks OK to me, I can test on other platforms too. But it does not apply
against current -git:
patching file Makefile
patching file configure
Hunk #3 FAILED at 235.
1 out of 9 hunks FAILED -- saving rejects to file configure.rej
Can you update and resend? Thanks!
--
Jens Axboe
next prev parent reply other threads:[~2013-03-13 15:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 2:40 [PATCH/RFC] Improve cross-compile support Aaron Carroll
2013-03-13 14:59 ` Jens Axboe [this message]
2013-03-14 0:09 ` Aaron Carroll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130313145930.GJ25165@kernel.dk \
--to=axboe@kernel.dk \
--cc=aaronc@cse.unsw.edu.au \
--cc=fio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.