From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 2/9] dfu: Support larger than memory transfers.
Date: Wed, 13 Mar 2013 11:05:59 -0400 [thread overview]
Message-ID: <20130313150559.GL23324@bill-the-cat> (raw)
In-Reply-To: <20130311110341.1ef4cc86@amdc308.digital.local>
On Mon, Mar 11, 2013 at 11:03:41AM +0100, Lukasz Majewski wrote:
> Hi Tom,
>
>
> >
> > > From: Pantelis Antoniou <panto@antoniou-consulting.com>
> > >
> > > Previously we didn't support upload/download larger than available
> > > memory. This is pretty bad when you have to update your root
> > > filesystem for example.
> > >
> > > This patch removes that limitation (and the crashes when you
> > > transfered any file larger than 4MB) by making raw image writes be
> > > done in chunks and making file maximum size be configurable.
> > >
> > > The sequence number is a 16 bit counter; make sure we handle
> > > rollover correctly. This fixes the wrong transfers for large (>
> > > 256MB) images.
> > >
> > > Also utilize a variable to handle initialization, so that we don't
> > > rely on just the counter sent by the host.
> > >
> > > Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
> > > Signed-off-by: Tom Rini <trini@ti.com>
> >
> > Acked-by: Lukasz Majewski <l.majewski@samsung.com>
> >
> > Test-hw: Exynos 4210 (Trats)
> >
> > Tested-by: Lukasz Majewski <l.majewski@samsung.com>
>
> Sorry but, I've found a regression for reading image from a file
> system. It happens with EXT4 mmc read (like uImage).
>
> mmc_file_op: ext4load mmc 0:2 /uImage 0x0 0 0x7f95dc98
> ** File not found 0x0 **
> dfu: Read error!
>
> ext4load params:
> ext4load - load binary file from a Ext4 filesystem
>
> Usage:
> ext4load <interface> <dev[:part]> [addr] [filename] [bytes]
This is a bug, but this is not a regression. As I sent in another
email, the issue is that ext4write takes arguments backwards from
fatwrite/fatload/ext4load so the line here has always been wrong.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130313/d8ce1aca/attachment.pgp>
next prev parent reply other threads:[~2013-03-13 15:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-08 17:37 [U-Boot] [PATCH v5 0/9] Improve DFU support, enable for am335x_evm Tom Rini
2013-03-08 17:37 ` [U-Boot] [PATCH v5 1/9] README: Document current DFU CONFIG options Tom Rini
2013-03-08 17:37 ` [U-Boot] [PATCH v5 2/9] dfu: Support larger than memory transfers Tom Rini
2013-03-11 9:38 ` Lukasz Majewski
2013-03-11 10:03 ` Lukasz Majewski
2013-03-11 12:55 ` Tom Rini
2013-03-13 15:05 ` Tom Rini [this message]
2013-03-13 15:25 ` Tom Rini
2013-03-13 19:57 ` Tom Rini
2013-03-14 8:22 ` Lukasz Majewski
2013-03-11 11:36 ` [U-Boot] Nand flash (supports ONFI) TigerLiu at viatech.com.cn
2013-03-11 11:56 ` Jagan Teki
2013-03-12 2:19 ` TigerLiu at viatech.com.cn
2013-03-08 17:37 ` [U-Boot] [PATCH v5 3/9] dfu: Change indentation of defines in <dfu.h> Tom Rini
2013-03-08 17:37 ` [U-Boot] [PATCH v5 4/9] nand: Extend nand_(read|write)_skip_bad with *actual and limit parameters Tom Rini
2013-03-09 1:00 ` Scott Wood
2013-03-08 17:37 ` [U-Boot] [PATCH v5 5/9] cmd_nand.c: Fix CONFIG_CMD_NAND_YAFFS Tom Rini
2013-03-08 17:37 ` [U-Boot] [PATCH v5 6/9] dfu: NAND specific routines for DFU operation Tom Rini
2013-03-09 1:08 ` Scott Wood
2013-03-13 20:04 ` Tom Rini
2013-03-08 17:37 ` [U-Boot] [PATCH v5 7/9] am335x_evm: Define CONFIG_SYS_CACHELINE_SIZE Tom Rini
2013-03-08 17:37 ` [U-Boot] [PATCH v5 8/9] am335x_evm: Add CONFIG_CMD_MTDPARTS and relevant defaults Tom Rini
2013-03-08 17:37 ` [U-Boot] [PATCH v5 9/9] am335x_evm: Enable DFU for NAND and MMC, provide example alt_infos Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130313150559.GL23324@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.