Re: i915 fails to build on 32bit Systems

[Ben Widawsky <ben@bwidawsk.net>]

On Wed, Mar 13, 2013 at 07:33:42PM +0100, Egbert Eich wrote:
> i915.ko does not build due to the following function in i915_debugfs.c:
> 
> i915_min_freq_set(void *data, u64 val)
> {
>         ...
>         dev_priv->rps.min_delay = val / GT_FREQUENCY_MULTIPLIER;
>         ...
> }
> 
> Doing a 64bit integer division on 32bit requires a
> compiler run time library to be linked in, otherwise 
> the symbol __udivdi3 will be missing.
> 
> This was introduced with 
> 
> commit 2389cc5006861a8e024a23cb73605f2ab6a5afe8
> Author: Kees Cook <keescook@chromium.org>
> Date:   Sun Mar 10 14:10:06 2013 -0700
> 
>     drm/i915: use simple attribute in debugfs routines
> 
> before this val was a simple int.
> 
> Cheers,
> 	Egbert.

We (Daniel) knows about this already... My question is, isn't this
already doable in sysfs. Can't we just kill the debugfs version now?

-- 
Ben Widawsky, Intel Open Source Technology Center