From: Sascha Hauer <s.hauer@pengutronix.de>
To: Cerrato Renaud <r.cerrato@til-technologies.fr>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 4/5] gadget: possible null pointer dereference fix
Date: Thu, 14 Mar 2013 08:35:41 +0100 [thread overview]
Message-ID: <20130314073541.GC1906@pengutronix.de> (raw)
In-Reply-To: <514082C7.9090502@til-technologies.fr>
On Wed, Mar 13, 2013 at 02:44:39PM +0100, Cerrato Renaud wrote:
> This patch fix a possible null pointer dereference exception because of a missing null check on cdev->config
>
> Signed-off-by: Cerrato Renaud <r.cerrato@til-technologies.fr>
> ---
> drivers/usb/gadget/composite.c | 23 +++++++++++++----------
> 1 files changed, 13 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
> index 9af115e..1f6c5b2 100644
> --- a/drivers/usb/gadget/composite.c
> +++ b/drivers/usb/gadget/composite.c
> @@ -777,18 +777,21 @@ unknown:
> * recipients (endpoint, other, WUSB, ...) to the current
> * configuration code.
> */
> - f = cdev->config->interface[intf];
> - if (f && f->setup)
> - value = f->setup(f, ctrl);
> - else
> - f = NULL;
> + if(cdev->config) {
please do a:
if (!cdev->config)
goto out;
instead.
Your patch is whitespace damaged, I won't be able to apply it.
As Jean-Christophe mentioned, you should use git-send-mail for sending
your patches. It does things just right.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-03-14 7:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 13:44 [PATCH 4/5] gadget: possible null pointer dereference fix Cerrato Renaud
2013-03-14 7:35 ` Sascha Hauer [this message]
2013-03-14 10:01 ` Cerrato Renaud
2013-03-14 10:34 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130314073541.GC1906@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=r.cerrato@til-technologies.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.