Re: [LTP] [PATCH 2/2] ltp: Add support for Imagination Technologies Meta

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1.1: Type: Text/Plain, Size: 1169 bytes --]

On Wednesday 13 March 2013 13:28:08 Markos Chandras wrote:
> On 13 March 2013 17:22, Mike Frysinger wrote:
> >> -#if defined(__hppa__)
> >> +#if defined(__hppa__) || (__metag__)
> > 
> > you're missing "defined"
> 
> Looking a couple of lines above this I see the following:
> 
> #if defined (__s390__) || (__s390x__)
> 
> so I assumed this is the desired style for multiple "#if defined"
> constructs.

nope, that's a bug too

> >>       ret = clone(fn, stack, clone_flags, arg);
> >>  
> >>  #elif defined(__ia64__)
> >>  
> >>       ret = clone2(fn, stack, stack_size, clone_flags, arg, NULL, NULL,
> >>       NULL);
> > 
> > i wonder if we could make this into a runtime test.  like declare a
> > buffer on the stack, then call alloca(), and compare the resulting
> > pointers.
> 
> If you ask me, I prefer the way it is now.

the advantage is that the next random person to grow their stock in the 
opposite direction won't have to update this hard coded list.  and if it was 
written this way earlier, you wouldn't be here right now either ;).

not saying you must do this ... fix the defined checks and we can merge that
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 238 bytes --]

------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list