From: Oleg Nesterov <oleg@redhat.com>
To: liguang <lig.fnst@cn.fujitsu.com>
Cc: viro@zeniv.linux.org.uk, edumazet@google.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] task_work: check callback if it's NULL
Date: Thu, 14 Mar 2013 15:43:07 +0100 [thread overview]
Message-ID: <20130314144307.GB16136@redhat.com> (raw)
In-Reply-To: <1363247865-3531-2-git-send-email-lig.fnst@cn.fujitsu.com>
On 03/14, liguang wrote:
>
> Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
> ---
> kernel/task_work.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/task_work.c b/kernel/task_work.c
> index 0bf4258..f458b08 100644
> --- a/kernel/task_work.c
> +++ b/kernel/task_work.c
> @@ -75,7 +75,8 @@ void task_work_run(void)
>
> do {
> next = work->next;
> - work->func(work);
> + if (unlikely(work->func))
> + work->func(work);
Why?
Oleg.
next prev parent reply other threads:[~2013-03-14 14:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-14 7:57 [PATCH 1/2] task_work: make FIFO task_work list liguang
2013-03-14 7:57 ` [PATCH 2/2] task_work: check callback if it's NULL liguang
2013-03-14 14:43 ` Oleg Nesterov [this message]
2013-03-15 0:20 ` li guang
2013-03-15 1:01 ` Li Zefan
2013-03-15 1:26 ` li guang
2013-03-15 1:43 ` Li Zefan
2013-03-15 2:29 ` li guang
2013-03-14 14:40 ` [PATCH 1/2] task_work: make FIFO task_work list Oleg Nesterov
2013-03-15 0:16 ` li guang
2013-03-15 14:34 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130314144307.GB16136@redhat.com \
--to=oleg@redhat.com \
--cc=edumazet@google.com \
--cc=lig.fnst@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.