From: Gleb Natapov <gleb@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, kvm <kvm@vger.kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v2] KVM: x86: Rework INIT and SIPI handling
Date: Thu, 14 Mar 2013 16:53:10 +0200 [thread overview]
Message-ID: <20130314145310.GW11223@redhat.com> (raw)
In-Reply-To: <20130314143259.GA4185@amt.cnet>
On Thu, Mar 14, 2013 at 11:32:59AM -0300, Marcelo Tosatti wrote:
> > > Also the fact kvm_apic_accept_events() is called from sites is annoying,
> > > why is that necessary again?
> >
> > - to avoid having pending events in the APIC when delivering mp_state
> > to user space
> > - to keep mp_state correct after waking up from kvm_vcpu_block (we
> > could otherwise walk through code paths with the wrong state)
> > - to process pending events when the VCPU was running
> >
> > Jan
>
> Ok, its alright (multiple callsites). Perhaps second and third points to
> be collapsed into a single one if moved outside vcpu_enter_guest.
Lets not forget that the point of all this changes was to properly
handle INIT wrt nested guests. I wonder how implementing it will affect
all the call sites. I doubt we want to handle nested vmexit at each one one
them.
--
Gleb.
prev parent reply other threads:[~2013-03-14 14:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 11:42 [PATCH v2] KVM: x86: Rework INIT and SIPI handling Jan Kiszka
2013-03-13 12:27 ` Paolo Bonzini
2013-03-13 12:42 ` Jan Kiszka
2013-03-13 14:08 ` Gleb Natapov
2013-03-14 0:08 ` Marcelo Tosatti
2013-03-14 2:10 ` Marcelo Tosatti
2013-03-14 10:15 ` Jan Kiszka
2013-03-14 11:24 ` Gleb Natapov
2013-03-14 11:29 ` Jan Kiszka
2013-03-14 12:12 ` Gleb Natapov
2013-03-14 12:16 ` Jan Kiszka
2013-03-14 12:18 ` Gleb Natapov
2013-03-14 12:25 ` Jan Kiszka
2013-03-14 12:28 ` Gleb Natapov
2013-03-14 15:32 ` Jan Kiszka
2013-03-14 15:46 ` Gleb Natapov
2013-03-14 14:32 ` Marcelo Tosatti
2013-03-14 14:53 ` Gleb Natapov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130314145310.GW11223@redhat.com \
--to=gleb@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.