All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nftables v2] nftables: fix compilation when nf-netlink is a module
Date: Thu, 14 Mar 2013 16:43:47 +0100	[thread overview]
Message-ID: <20130314154347.GA15759@localhost> (raw)
In-Reply-To: <1362577327-16634-1-git-send-email-nicolas.dichtel@6wind.com>

On Wed, Mar 06, 2013 at 02:42:07PM +0100, Nicolas Dichtel wrote:
> nftables uses nfnl_[un]lock() and thus depends on
> CONFIG_NETFILTER_NETLINK.  It's not possible to have nftables
> built-in when CONFIG_NETFILTER_NETLINK is set to m.
> 
> I also add a dependancy between NETFILTER_XTABLES and NFT_COMPAT
> instead of automatically set NETFILTER_XTABLES when NFT_COMPAT is
> set. This is to avoid a circular dependency:
> 
> net/netfilter/Kconfig:432:error: recursive dependency detected!
> net/netfilter/Kconfig:432:	symbol NF_TABLES depends on NETFILTER_NETLINK
> net/netfilter/Kconfig:4:	symbol NETFILTER_NETLINK is selected by NETFILTER_NETLINK_ACCT
> net/netfilter/Kconfig:7:	symbol NETFILTER_NETLINK_ACCT is selected by NETFILTER_XT_MATCH_NFACCT
> net/netfilter/Kconfig:1087:	symbol NETFILTER_XT_MATCH_NFACCT depends on NETFILTER_XTABLES
> net/netfilter/Kconfig:425:	symbol NETFILTER_XTABLES is selected by NFT_COMPAT
> net/netfilter/Kconfig:478:	symbol NFT_COMPAT depends on NF_TABLES

Applied, thanks Nicolas.

      reply	other threads:[~2013-03-14 15:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-06 10:26 [PATCH nftables] nftables: fix compilation when nf-netlink is a module Nicolas Dichtel
2013-03-06 11:20 ` Nicolas Dichtel
2013-03-06 13:42   ` [PATCH nftables v2] " Nicolas Dichtel
2013-03-14 15:43     ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130314154347.GA15759@localhost \
    --to=pablo@netfilter.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=nicolas.dichtel@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.