From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 1/4] drm/i915: Remove unused file arg from execbuf Date: Thu, 14 Mar 2013 09:06:48 -0700 Message-ID: <20130314160646.GA10890@bwidawsk.net> References: <1363220468-1718-1-git-send-email-ben@bwidawsk.net> <20130314085641.GC20960@cantiga.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from shiva.localdomain (209-20-75-48.static.cloud-ips.com [209.20.75.48]) by gabe.freedesktop.org (Postfix) with ESMTP id CF670E6989 for ; Thu, 14 Mar 2013 09:04:51 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130314085641.GC20960@cantiga.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Mar 14, 2013 at 08:56:41AM +0000, Chris Wilson wrote: > I was hoping for something a little more magical. I couldn't spot any > mistakes - the only thing missing is a hint as to why these are useful. > > Acked-by: Chris Wilson > -Chris I'm pretty sure you asked for magic the last time sent this patch. Anyway, I can probably talk a little bit without disclosing the secretz. Primarily the goal is to be able to easily queue up the work. Packing more into the eb struct gives a nice compact /thing/ which I can put into a list for later execution. Now, the deferred execution has it's own pitfalls, and I'd prefer not to get too far into that since I think these cleanups are decent on their own. > > -- > Chris Wilson, Intel Open Source Technology Centre -- Ben Widawsky, Intel Open Source Technology Center