From: Chris Mason <chris.mason@fusionio.com>
To: Liu Bo <bo.li.liu@oracle.com>
Cc: "dsterba@suse.cz" <dsterba@suse.cz>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] Btrfs: get better concurrency for snapshot-aware defrag work
Date: Thu, 14 Mar 2013 14:38:29 -0400 [thread overview]
Message-ID: <20130314183829.GC18457@shiny.masoncoding.com> (raw)
In-Reply-To: <20130312014402.GC31527@liubo.jp.oracle.com>
On Mon, Mar 11, 2013 at 07:44:04PM -0600, Liu Bo wrote:
> On Mon, Mar 11, 2013 at 06:26:40PM +0100, David Sterba wrote:
> > On Mon, Mar 11, 2013 at 05:20:58PM +0800, Liu Bo wrote:
> > > Using spinning case instead of blocking will result in better concurrency
> > > overall.
> >
> > Do you have numbers to support that?
> >
>
> Sorry, I don't, just judging from what leave_spinning is desiged for and the
> similar usecases, like insert_reserved_file_extents(), which is also involved in
> endio write worker.
Leaving the path spinning is always faster. As long as you're sure the
code inside doesn't schedule it is the right choice.
-chris
next prev parent reply other threads:[~2013-03-14 18:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 9:20 [PATCH] Btrfs: get better concurrency for snapshot-aware defrag work Liu Bo
2013-03-11 17:26 ` David Sterba
2013-03-12 1:44 ` Liu Bo
2013-03-14 18:38 ` Chris Mason [this message]
2013-03-15 1:39 ` Liu Bo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130314183829.GC18457@shiny.masoncoding.com \
--to=chris.mason@fusionio.com \
--cc=bo.li.liu@oracle.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.