From: Dave Chinner <david@fromorbit.com>
To: Philip White <pwhite@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 11/18] xfstests: add tests into tests/xfs/group
Date: Fri, 15 Mar 2013 19:31:57 +1100 [thread overview]
Message-ID: <20130315083157.GD2559@dastard> (raw)
In-Reply-To: <20130314130611.935D953DEAF8@polaris-admin.engr.sgi.com>
On Thu, Mar 14, 2013 at 06:06:11AM -0700, Philip White wrote:
> From: Phil White <pwhite@sgi.com>
>
>
> This is a rebasing & resubmit of a dchinner patch. His comments on the
> original:
> -----------------
> And into tests/xfs. Tests found and moved via:
>
> $ grep "supported_fs xfs$" [0-2]* | cut -d : -f 1 > xfs.tests
> $ for i in `cat xfs.tests`; do
> > git mv $i* tests/xfs/
> > grep ^$i group >> tests/xfs/group
> > sed -i -e "/^$i/d" group
> > done
>
> Output now looks like:
>
> sudo ./check -g quick -r
> FSTYP -- xfs (debug)
> PLATFORM -- Linux/x86_64 test-1 3.5.0-rc5-dgc+
> MKFS_OPTIONS -- -f -bsize=4096 /dev/vdb
> MOUNT_OPTIONS -- /dev/vdb /mnt/scratch
>
> xfs/170 4s
> generic/120 16s
> generic/248 0s
> generic/213 0s
> generic/256 39s
> xfs/121 6s
> xfs/026 11s
> generic/131 1s
> xfs/187 1s
> generic/135 0s
> ....
> -----------------
> For ease of reviewing, I put all the actual test movements into a separate
> patch.
Where is that patch - I don't see it in the series.
As it is, moving the files in a different patch to the group file
changes breaks xfstests. One of the things I made sure of was that
after each patch, the entire set of tests still ran properly with
something like "./check -g auto", and this separation looks lik eit
breaks that.
As it is, nobody is going to review a patch that has a diffstat of
+/-80,000 lines, which means it's irrelevant if it is in another
patch or not. As such, you don't need to send such patches as traditional diffs -
the git aware diff format is far better for this and easy to review
even whenteh file movement in is the same patch. See
http://oss.sgi.com/archives/xfs/2012-07/msg00389.html
To see how i sent this previously.
You are using git (though a very old version), so you should be bale
to get patches output in the correct manner...
-Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-03-15 8:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-14 13:06 [PATCH 11/18] xfstests: add tests into tests/xfs/group Philip White
2013-03-15 8:31 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130315083157.GD2559@dastard \
--to=david@fromorbit.com \
--cc=pwhite@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.