All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Eric Sandeen <sandeen@redhat.com>,
	linux-btrfs@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH 3/3 V4] xfstests: btrfs tests for basic informational commands
Date: Fri, 15 Mar 2013 21:16:25 +1100	[thread overview]
Message-ID: <20130315101625.GE6369@dastard> (raw)
In-Reply-To: <5140CD26.7050201@sandeen.net>

On Wed, Mar 13, 2013 at 02:01:58PM -0500, Eric Sandeen wrote:
> Run basic btrfs information commands in various ways, performing
> sanity tests of: filesystem show, label, sync, and device stats
> (sync is included just because it's simple).  These are mostly
> just smoke tests, although for example show by label & UUID
> should verify that the correct fs was shown.
> 
> This also adds quite a few new filters to accommodate the output
> of the new commands.
> 
> Cc: linux-btrfs@vger.kernel.org
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
> 
> V2: sort & uniq device stats output to account for variable
> nrs. of devices.  Optionally check that the proper nr. of
> devices was returned, as well.
> 
> V3: _filter_uuid needs to pay attention to $1, not hope
> that the caller has set $UUID.  Oops.
> 
> V4: fix stats filter to set UNIQ_OPT in both cases, ugh.

Something I just noticed in this commit:

> +# get standard environment, filters and checks
> +. ./common.rc
> +. ./btrfs.filter

That should probably have been named "common.filter.btrfs".
I found this updating my patchset that moves all the common.* files
into a common/ directory....

I'll rename it to common/filter.btrfs....

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Eric Sandeen <sandeen@redhat.com>,
	linux-btrfs@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH 3/3 V4] xfstests: btrfs tests for basic informational commands
Date: Fri, 15 Mar 2013 21:16:25 +1100	[thread overview]
Message-ID: <20130315101625.GE6369@dastard> (raw)
In-Reply-To: <5140CD26.7050201@sandeen.net>

On Wed, Mar 13, 2013 at 02:01:58PM -0500, Eric Sandeen wrote:
> Run basic btrfs information commands in various ways, performing
> sanity tests of: filesystem show, label, sync, and device stats
> (sync is included just because it's simple).  These are mostly
> just smoke tests, although for example show by label & UUID
> should verify that the correct fs was shown.
> 
> This also adds quite a few new filters to accommodate the output
> of the new commands.
> 
> Cc: linux-btrfs@vger.kernel.org
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
> 
> V2: sort & uniq device stats output to account for variable
> nrs. of devices.  Optionally check that the proper nr. of
> devices was returned, as well.
> 
> V3: _filter_uuid needs to pay attention to $1, not hope
> that the caller has set $UUID.  Oops.
> 
> V4: fix stats filter to set UNIQ_OPT in both cases, ugh.

Something I just noticed in this commit:

> +# get standard environment, filters and checks
> +. ./common.rc
> +. ./btrfs.filter

That should probably have been named "common.filter.btrfs".
I found this updating my patchset that moves all the common.* files
into a common/ directory....

I'll rename it to common/filter.btrfs....

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2013-03-15 10:16 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-13 14:57 [PATCH 0/3] xfstests patches Eric Sandeen
2013-03-13 14:57 ` [PATCH 1/3] xfstests: add 274 to the prealloc group Eric Sandeen
2013-03-13 17:36   ` Rich Johnston
2013-03-13 14:57 ` [PATCH 2/3] xfstests: keep newlines out of SCRATCH_DEV_POOL Eric Sandeen
2013-03-13 14:57   ` Eric Sandeen
2013-03-13 17:43   ` Rich Johnston
2013-03-13 17:43     ` Rich Johnston
2013-03-13 17:45     ` Eric Sandeen
2013-03-13 17:45       ` Eric Sandeen
2013-03-13 14:57 ` [PATCH 3/3] xfstests: btrfs tests for basic informational commands Eric Sandeen
2013-03-13 14:57   ` Eric Sandeen
2013-03-13 15:32   ` Stefan Behrens
2013-03-13 15:32     ` Stefan Behrens
2013-03-13 16:17     ` Eric Sandeen
2013-03-13 16:17       ` Eric Sandeen
2013-03-13 17:47       ` Rich Johnston
2013-03-13 17:47         ` Rich Johnston
2013-03-13 16:38   ` [PATCH 3/3 V2] " Eric Sandeen
2013-03-13 16:38     ` Eric Sandeen
2013-03-13 18:53     ` [PATCH 3/3 V3] " Eric Sandeen
2013-03-13 18:53       ` Eric Sandeen
2013-03-13 19:00       ` Stefan Behrens
2013-03-13 19:00         ` Stefan Behrens
2013-03-13 19:01       ` [PATCH 3/3 V4] " Eric Sandeen
2013-03-13 19:01         ` Eric Sandeen
2013-03-14 13:01         ` Rich Johnston
2013-03-14 13:01           ` Rich Johnston
2013-03-14 13:35           ` Stefan Behrens
2013-03-14 13:35             ` Stefan Behrens
2013-03-15 10:16         ` Dave Chinner [this message]
2013-03-15 10:16           ` Dave Chinner
2013-03-15 13:46           ` Eric Sandeen
2013-03-15 13:46             ` Eric Sandeen
2013-03-15 14:23             ` Rich Johnston
2013-03-15 14:23               ` Rich Johnston
2013-03-15 14:36               ` Eric Sandeen
2013-03-15 14:36                 ` Eric Sandeen
2013-03-18 13:30                 ` Rich Johnston
2013-03-18 13:30                   ` Rich Johnston
2013-03-19 14:15                 ` Rich Johnston
2013-03-19 14:15                   ` Rich Johnston
2013-03-14 17:16 ` [PATCH 0/3] xfstests patches Rich Johnston
2013-03-15  5:43   ` Dave Chinner
2013-03-15 13:38     ` Rich Johnston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130315101625.GE6369@dastard \
    --to=david@fromorbit.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=sandeen@redhat.com \
    --cc=sandeen@sandeen.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.