From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from userp1040.oracle.com ([156.151.31.81]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UGXvx-0007E0-8c for kexec@lists.infradead.org; Fri, 15 Mar 2013 16:56:46 +0000 Date: Fri, 15 Mar 2013 12:56:36 -0400 From: Konrad Rzeszutek Wilk Subject: Re: [Xen-devel] [PATCH 1/2] xen: Improve calculation of beginning of virtual address space Message-ID: <20130315165636.GA16644@phenom.dumpdata.com> References: <20130315150921.GB12758@debian70-amd64.local.net-space.pl> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20130315150921.GB12758@debian70-amd64.local.net-space.pl> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Daniel Kiper Cc: kexec@lists.infradead.org, xen-devel@lists.xensource.com, anderson@redhat.com, crash-utility@redhat.com On Fri, Mar 15, 2013 at 04:09:21PM +0100, Daniel Kiper wrote: > Xen changeset 26447 (x86: re-introduce map_domain_page() et al) once again > altered virtual address space. Current algorithm calculating its start could > not cope with that change. New version establishes this value on the base of > image start address and is more generic. And it works with the older (3.4) hypervisors binary image? > > Signed-off-by: Daniel Kiper > > diff -Npru crash-6.1.4.orig/xen_hyper.c crash-6.1.4/xen_hyper.c > --- crash-6.1.4.orig/xen_hyper.c 2013-02-14 21:38:54.000000000 +0100 > +++ crash-6.1.4/xen_hyper.c 2013-03-15 13:11:16.595713662 +0100 > @@ -43,10 +43,14 @@ xen_hyper_init(void) > #endif > > #ifdef X86_64 > - if (xen_major_version() >= 4) > - xht->xen_virt_start = 0xffff82c480000000; > - else > - xht->xen_virt_start = 0xffff828c80000000; > + xht->xen_virt_start = symbol_value("start"); > + > + /* > + * Xen virtual mapping is aligned to 1 GiB boundary. > + * Image starts no more than 1 GiB below > + * beginning of virtual address space. > + */ > + xht->xen_virt_start &= 0xffffffffc0000000; > #endif > > if (machine_type("X86_64") && > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel > _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [Xen-devel] [PATCH 1/2] xen: Improve calculation of beginning of virtual address space Date: Fri, 15 Mar 2013 12:56:36 -0400 Message-ID: <20130315165636.GA16644@phenom.dumpdata.com> References: <20130315150921.GB12758@debian70-amd64.local.net-space.pl> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20130315150921.GB12758-ri7RxvcH2jeCtUdEpT35kVHq7GDQUN6HS7aiLakcVNdmR6Xm/wNWPw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kexec" Errors-To: kexec-bounces+glkk-kexec=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Daniel Kiper Cc: kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, xen-devel-GuqFBffKawuULHF6PoxzQEEOCMrvLtNR@public.gmane.org, anderson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, crash-utility-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org List-Id: xen-devel@lists.xenproject.org On Fri, Mar 15, 2013 at 04:09:21PM +0100, Daniel Kiper wrote: > Xen changeset 26447 (x86: re-introduce map_domain_page() et al) once again > altered virtual address space. Current algorithm calculating its start could > not cope with that change. New version establishes this value on the base of > image start address and is more generic. And it works with the older (3.4) hypervisors binary image? > > Signed-off-by: Daniel Kiper > > diff -Npru crash-6.1.4.orig/xen_hyper.c crash-6.1.4/xen_hyper.c > --- crash-6.1.4.orig/xen_hyper.c 2013-02-14 21:38:54.000000000 +0100 > +++ crash-6.1.4/xen_hyper.c 2013-03-15 13:11:16.595713662 +0100 > @@ -43,10 +43,14 @@ xen_hyper_init(void) > #endif > > #ifdef X86_64 > - if (xen_major_version() >= 4) > - xht->xen_virt_start = 0xffff82c480000000; > - else > - xht->xen_virt_start = 0xffff828c80000000; > + xht->xen_virt_start = symbol_value("start"); > + > + /* > + * Xen virtual mapping is aligned to 1 GiB boundary. > + * Image starts no more than 1 GiB below > + * beginning of virtual address space. > + */ > + xht->xen_virt_start &= 0xffffffffc0000000; > #endif > > if (machine_type("X86_64") && > > _______________________________________________ > Xen-devel mailing list > Xen-devel-GuqFBffKawuEi8DpZVb4nw@public.gmane.org > http://lists.xen.org/xen-devel >