From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: "Liu, Chuansheng" <chuansheng.liu@intel.com>
Cc: "Li, Fei" <fei.li@intel.com>, "rjw@sisk.pl" <rjw@sisk.pl>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"ldewangan@nvidia.com" <ldewangan@nvidia.com>
Subject: Re: [PATCH] pm: print the name of failed suspend function for platform device
Date: Fri, 15 Mar 2013 20:54:19 -0700 [thread overview]
Message-ID: <20130316035419.GA12634@kroah.com> (raw)
In-Reply-To: <27240C0AC20F114CBF8149A2696CBE4A25BE7A@SHSMSX101.ccr.corp.intel.com>
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Sat, Mar 16, 2013 at 01:22:31AM +0000, Liu, Chuansheng wrote:
> Hello Greg,
>
> Double checked, there is no your response before.
> Can you consider it again? Thanks.
Consider what? I get about 250 patches a _week_, I honestly do not
remember your specific patch, nor do I have it anywhere in front of me.
> Since we have printed the failure info, why not enhance it a bit:)
>
> Example without this patch:
> pm_op(): platform_pm_suspend+0x0/0x50 returns -11
> PM: Device power.0 failed to suspend: error -11
>
> And with this patch:
> platform_pm_suspend(): power_suspend+0x0/0x30 returns -11
> pm_op(): platform_pm_suspend+0x0/0x80 returns -11
> PM: Device power.0 failed to suspend: error -11
Ok, fine, get the PM maintainer to accept the patch then, resend it, cc:
the proper people and it will be considered. If I hate it, I'll tell
you.
greg k-h
next prev parent reply other threads:[~2013-03-16 3:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-05 5:13 [PATCH] pm: print the name of failed suspend function for platform device fli24
2013-03-11 1:41 ` Liu, Chuansheng
2013-03-15 19:20 ` gregkh
2013-03-16 1:22 ` Liu, Chuansheng
2013-03-16 3:54 ` gregkh [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-03-18 5:58 Li Fei
2013-03-18 16:05 ` Greg KH
2013-03-19 2:05 ` Li, Fei
2013-03-19 2:37 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130316035419.GA12634@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=chuansheng.liu@intel.com \
--cc=fei.li@intel.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.