From: Al Viro <viro@ZenIV.linux.org.uk>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
Anton Arapov <anton@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] uprobes: Use file_inode()
Date: Sun, 17 Mar 2013 18:25:50 +0000 [thread overview]
Message-ID: <20130317182550.GD21522@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20130317180036.GA16843@redhat.com>
On Sun, Mar 17, 2013 at 07:00:36PM +0100, Oleg Nesterov wrote:
> Cleanup. Now that we have f_inode/file_inode() we can use it
> instead of ->f_mapping->host.
No. This is *not* guaranteed to be the same thing in general; note that
e.g. for block devices ->f_mapping->host is *not* equal to file_inode().
It probably is valid in this particular case, but at the very least you
need to explain that in commit message, or soon we'll get the Knights of
Holy Commit Count(tm) crapping all over the tree, breaking stuff.
next prev parent reply other threads:[~2013-03-17 18:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-17 18:00 [PATCH] uprobes: Use file_inode() Oleg Nesterov
2013-03-17 18:25 ` Al Viro [this message]
2013-03-17 18:42 ` Oleg Nesterov
2013-03-18 18:43 ` [PATCH v2] " Oleg Nesterov
2013-03-21 6:06 ` Srikar Dronamraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130317182550.GD21522@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=anton@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.