From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/5] flite: new package
Date: Mon, 18 Mar 2013 10:43:10 +0100 [thread overview]
Message-ID: <20130318104310.718e14d0@skate> (raw)
In-Reply-To: <87vc8p3dfs.fsf@dell.be.48ers.dk>
On Sun, 17 Mar 2013 22:48:39 +0100, Peter Korsgaard wrote:
> Samuel> +FLITE_CONF_OPT = \
> Samuel> + $(if $(BR2_PREFER_STATIC_LIB),,--enable-shared)
>
> We're already pass --enable-shared in the autotools infrastructure, so
> why is this needed?
I've tested without this part, and the package builds fine, so I'm
also not sure why it's needed.
> Samuel> +
> Samuel> +FLITE_INSTALL_STAGING_OPT = \
> Samuel> + INSTALLBINDIR=$(STAGING_DIR)/usr/bin \
> Samuel> + INSTALLLIBDIR=$(STAGING_DIR)/usr/lib \
> Samuel> + INSTALLINCDIR=$(STAGING_DIR)/usr/include/flite \
> Samuel> + install
> Samuel> +
> Samuel> +FLITE_INSTALL_TARGET_OPT = \
> Samuel> + INSTALLBINDIR=$(TARGET_DIR)/usr/bin \
> Samuel> + INSTALLLIBDIR=$(TARGET_DIR)/usr/lib \
> Samuel> + INSTALLINCDIR=$(TARGET_DIR)/usr/include/flite \
> Samuel> + install
>
> It could be good with a note about why this is needed (E.G. flite
> used a handwritten a Makefile which doesn't handle DESTDIR even
> though it uses autoconf).
Another option is to add a patch like:
Index: b/config/config.in
===================================================================
--- a/config/config.in
+++ b/config/config.in
@@ -49,6 +49,6 @@
prefix = @prefix@
exec_prefix = @exec_prefix@
EXEEXT = @EXEEXT@
-INSTALLBINDIR = @bindir@
-INSTALLLIBDIR = @libdir@
-INSTALLINCDIR = @includedir@/flite
+INSTALLBINDIR = $(DESTDIR)@bindir@
+INSTALLLIBDIR = $(DESTDIR)@libdir@
+INSTALLINCDIR = $(DESTDIR)@includedir@/flite
That said, the project hasn't done any release since 2009, so the
chances of getting this upstream are pretty small...
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-03-18 9:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 4:58 [Buildroot] [pull request v2] Pull request for branch for-master/armadeus/new-pkgs Samuel Martin
2013-03-12 4:58 ` [Buildroot] [PATCH 1/5] openobex: new package Samuel Martin
2013-03-13 7:42 ` Thomas Petazzoni
2013-03-13 23:06 ` Peter Korsgaard
2013-03-12 4:58 ` [Buildroot] [PATCH 2/5] ussp-push: " Samuel Martin
2013-03-13 7:45 ` Thomas Petazzoni
2013-03-13 23:07 ` Peter Korsgaard
2013-03-12 4:58 ` [Buildroot] [PATCH 3/5] urg: " Samuel Martin
2013-03-17 21:33 ` Peter Korsgaard
2013-03-12 4:58 ` [Buildroot] [PATCH 4/5] flite: " Samuel Martin
2013-03-17 21:48 ` Peter Korsgaard
2013-03-18 9:43 ` Thomas Petazzoni [this message]
2013-03-12 4:58 ` [Buildroot] [PATCH 5/5] libcanfestival: " Samuel Martin
2013-03-17 22:05 ` Peter Korsgaard
2013-03-18 10:30 ` Yegor Yefremov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130318104310.718e14d0@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.