[PATCH] meta-networking: Add LAYERVERSION and LAYERDEPENDS

[PATCH] meta-networking: Add LAYERVERSION and LAYERDEPENDS

[wenzong.fan]

From: Wenzong Fan <wenzong.fan@windriver.com>

Add LAYERVERSION and LAYERDEPENDS to layer.conf

Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com>
---
 meta-networking/conf/layer.conf |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/meta-networking/conf/layer.conf b/meta-networking/conf/layer.conf
index 1ea2bc2..f75080a 100644
--- a/meta-networking/conf/layer.conf
+++ b/meta-networking/conf/layer.conf
@@ -9,3 +9,8 @@ BBFILE_COLLECTIONS += "networking"
 BBFILE_PATTERN_networking := "^${LAYERDIR}/"
 BBFILE_PRIORITY_networking = "5"
 
+# This should only be incremented on significant changes that will
+# cause compatibility issues with other layers
+LAYERVERSION_networking = "1"
+
+LAYERDEPENDS_networking = "core"
-- 
1.7.10.4

Re: [PATCH] meta-networking: Add LAYERVERSION and LAYERDEPENDS

[Paul Eggleton]

On Monday 11 March 2013 17:38:39 wenzong.fan@windriver.com wrote:
> From: Wenzong Fan <wenzong.fan@windriver.com>
> 
> Add LAYERVERSION and LAYERDEPENDS to layer.conf
> 
> Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com>
> ---
>  meta-networking/conf/layer.conf |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/meta-networking/conf/layer.conf
> b/meta-networking/conf/layer.conf index 1ea2bc2..f75080a 100644
> --- a/meta-networking/conf/layer.conf
> +++ b/meta-networking/conf/layer.conf
> @@ -9,3 +9,8 @@ BBFILE_COLLECTIONS += "networking"
>  BBFILE_PATTERN_networking := "^${LAYERDIR}/"
>  BBFILE_PRIORITY_networking = "5"
> 
> +# This should only be incremented on significant changes that will
> +# cause compatibility issues with other layers
> +LAYERVERSION_networking = "1"
> +
> +LAYERDEPENDS_networking = "core"

This is good, but it might be useful to also set a versioned dependency on the 
core - that way if you attempt to use the denzil branch of OE-Core with master 
of one of these layers, instead of an error about incorrect indentation in 
python functions you get one specifically about the version being incorrect.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: [PATCH] meta-networking: Add LAYERVERSION and LAYERDEPENDS

[Joe MacDonald]

[-- Attachment #1: Type: text/plain, Size: 1775 bytes --]

Getting caught up ...

[Re: [oe] [PATCH] meta-networking: Add LAYERVERSION and LAYERDEPENDS] On 13.03.11 (Mon 15:38) Paul Eggleton wrote:

> On Monday 11 March 2013 17:38:39 wenzong.fan@windriver.com wrote:
> > From: Wenzong Fan <wenzong.fan@windriver.com>
> > 
> > Add LAYERVERSION and LAYERDEPENDS to layer.conf
> > 
> > Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com>
> > ---
> >  meta-networking/conf/layer.conf |    5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/meta-networking/conf/layer.conf
> > b/meta-networking/conf/layer.conf index 1ea2bc2..f75080a 100644
> > --- a/meta-networking/conf/layer.conf
> > +++ b/meta-networking/conf/layer.conf
> > @@ -9,3 +9,8 @@ BBFILE_COLLECTIONS += "networking"
> >  BBFILE_PATTERN_networking := "^${LAYERDIR}/"
> >  BBFILE_PRIORITY_networking = "5"
> > 
> > +# This should only be incremented on significant changes that will
> > +# cause compatibility issues with other layers
> > +LAYERVERSION_networking = "1"
> > +
> > +LAYERDEPENDS_networking = "core"
> 
> This is good, but it might be useful to also set a versioned dependency on the 
> core - that way if you attempt to use the denzil branch of OE-Core with master 
> of one of these layers, instead of an error about incorrect indentation in 
> python functions you get one specifically about the version being incorrect.

I agree.  This seems to have caused at least one person some headache
recently and I know I've had a few head-scratching moments when I was
burned by different trees being on incompatible branches.

Was there an update on this that I didn't see yet?  Or are you planning
one, Wenzong?  I can merge this now, but Paul's got a very good point, I
think.

-- 
-Joe MacDonald.
:wq

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [PATCH] meta-networking: Add LAYERVERSION and LAYERDEPENDS

[Joe MacDonald]

[-- Attachment #1: Type: text/plain, Size: 1127 bytes --]

[[oe] [PATCH] meta-networking: Add LAYERVERSION and LAYERDEPENDS] On 13.03.11 (Mon 17:38) wenzong.fan@windriver.com wrote:

> From: Wenzong Fan <wenzong.fan@windriver.com>
> 
> Add LAYERVERSION and LAYERDEPENDS to layer.conf
> 
> Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com>
> ---
>  meta-networking/conf/layer.conf |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/meta-networking/conf/layer.conf b/meta-networking/conf/layer.conf
> index 1ea2bc2..f75080a 100644
> --- a/meta-networking/conf/layer.conf
> +++ b/meta-networking/conf/layer.conf
> @@ -9,3 +9,8 @@ BBFILE_COLLECTIONS += "networking"
>  BBFILE_PATTERN_networking := "^${LAYERDIR}/"
>  BBFILE_PRIORITY_networking = "5"
>  
> +# This should only be incremented on significant changes that will
> +# cause compatibility issues with other layers
> +LAYERVERSION_networking = "1"
> +
> +LAYERDEPENDS_networking = "core"

I went ahead and merged this piece since on the whole it makes things
better by being there.  I'll take another patch for Paul's suggestion
whenever it's available.

-- 
-Joe MacDonald.
:wq

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]