All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH 2/18 V2]: PVH xen: add XENMEM_add_to_physmap_range
Date: Mon, 18 Mar 2013 12:38:12 -0400	[thread overview]
Message-ID: <20130318163812.GA27433@phenom.dumpdata.com> (raw)
In-Reply-To: <5147400F02000078000C6773@nat28.tlf.novell.com>

On Mon, Mar 18, 2013 at 03:25:51PM +0000, Jan Beulich wrote:
> >>> On 18.03.13 at 15:28, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:
> > On Fri, Mar 15, 2013 at 05:20:18PM -0700, Mukesh Rathor wrote:
> >> In this patch we add a new function xenmem_add_to_physmap_range(), and
> >> change xenmem_add_to_physmap_once parameters so it can be called from
> >> xenmem_add_to_physmap_range. There is no PVH specific change here.
> >> 
> >> Changes in V2:
> >>    - Do not break parameter so xenmem_add_to_physmap_once() but pass in
> >>      struct xen_add_to_physmap.
> > 
> > Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> 
> I'm confused: A little earlier you sent a response raising several
> issues, and now you send a Reviewed-by?

Sorry, I looked at it a first and it looked OK, so I did the Reviewed-by.

Then looked at some other patches, some cog in my brain did a late page-fault
on this patch and I went back in here. Then realized that there certain
things I was not sure off and asked Mukesh.

So, Reviewed-by rescinded for this patch right now. Thanks for catching that
process error.

> 
> Jan
> 

  reply	other threads:[~2013-03-18 16:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-16  0:20 [PATCH 2/18 V2]: PVH xen: add XENMEM_add_to_physmap_range Mukesh Rathor
2013-03-18 11:38 ` Jan Beulich
2013-03-18 20:15   ` Konrad Rzeszutek Wilk
2013-03-19  8:40     ` Jan Beulich
2013-03-19 13:40       ` Konrad Rzeszutek Wilk
2013-03-19 14:06         ` Jan Beulich
2013-03-21  1:01   ` Mukesh Rathor
2013-03-21 18:39     ` Konrad Rzeszutek Wilk
2013-03-18 13:59 ` Konrad Rzeszutek Wilk
2013-03-18 14:28 ` Konrad Rzeszutek Wilk
2013-03-18 15:25   ` Jan Beulich
2013-03-18 16:38     ` Konrad Rzeszutek Wilk [this message]
2013-03-21 14:53 ` Tim Deegan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130318163812.GA27433@phenom.dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=JBeulich@suse.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.