From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH 2/18 V2]: PVH xen: add XENMEM_add_to_physmap_range Date: Mon, 18 Mar 2013 12:38:12 -0400 Message-ID: <20130318163812.GA27433@phenom.dumpdata.com> References: <20130315172018.395bbbe3@mantra.us.oracle.com> <20130318142844.GI24560@phenom.dumpdata.com> <5147400F02000078000C6773@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <5147400F02000078000C6773@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel List-Id: xen-devel@lists.xenproject.org On Mon, Mar 18, 2013 at 03:25:51PM +0000, Jan Beulich wrote: > >>> On 18.03.13 at 15:28, Konrad Rzeszutek Wilk wrote: > > On Fri, Mar 15, 2013 at 05:20:18PM -0700, Mukesh Rathor wrote: > >> In this patch we add a new function xenmem_add_to_physmap_range(), and > >> change xenmem_add_to_physmap_once parameters so it can be called from > >> xenmem_add_to_physmap_range. There is no PVH specific change here. > >> > >> Changes in V2: > >> - Do not break parameter so xenmem_add_to_physmap_once() but pass in > >> struct xen_add_to_physmap. > > > > Reviewed-by: Konrad Rzeszutek Wilk > > I'm confused: A little earlier you sent a response raising several > issues, and now you send a Reviewed-by? Sorry, I looked at it a first and it looked OK, so I did the Reviewed-by. Then looked at some other patches, some cog in my brain did a late page-fault on this patch and I went back in here. Then realized that there certain things I was not sure off and asked Mukesh. So, Reviewed-by rescinded for this patch right now. Thanks for catching that process error. > > Jan >