All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
	target-devel@vger.kernel.org,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH V3 0/2] tcm_vhost hotplug/hotunplug support
Date: Mon, 18 Mar 2013 23:53:50 +0200	[thread overview]
Message-ID: <20130318215350.GA21091@redhat.com> (raw)
In-Reply-To: <1363643172.3156.62.camel@haakon2.linux-iscsi.org>

On Mon, Mar 18, 2013 at 02:46:12PM -0700, Nicholas A. Bellinger wrote:
> On Tue, 2013-03-12 at 10:45 +0800, Asias He wrote:
> > Changes in v3:
> > - Separate the bug fix to another thread
> > 
> > Changes in v2:
> > - Remove code duplication in tcm_vhost_{hotplug,hotunplug}
> > - Fix racing of vs_events_nr
> > - Add flush fix patch to this series
> > 
> > 
> > Asias He (2):
> >   tcm_vhost: Introduce tcm_vhost_check_feature()
> >   tcm_vhost: Add hotplug/hotunplug support
> > 
> >  drivers/vhost/tcm_vhost.c | 224 ++++++++++++++++++++++++++++++++++++++++++++--
> >  drivers/vhost/tcm_vhost.h |  10 +++
> >  2 files changed, 229 insertions(+), 5 deletions(-)
> > 
> 
> MST, are you OK with these two being applied to target-pending/for-next
> now..?
> 
> --nab

Sorry, no, I'd prefer we get userspace support in qemu in first.
If there's only a single user for this driver (kvmtool),
then it was a mistake to merge it, the right thing would be to freeze it
and look at whether we can drop it completely.

I really don't want this, I hope it will be merged and all will
be shiny, but I think it's wrong to rush in more code,
we have some time before the next merge window.

-- 
MST

  reply	other threads:[~2013-03-18 21:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-12  2:45 [PATCH V3 0/2] tcm_vhost hotplug/hotunplug support Asias He
2013-03-12  2:45 ` [PATCH V3 1/2] tcm_vhost: Introduce tcm_vhost_check_feature() Asias He
2013-03-12  2:45 ` [PATCH V3 2/2] tcm_vhost: Add hotplug/hotunplug support Asias He
2013-03-12  2:45 ` Asias He
2013-03-18 21:46 ` [PATCH V3 0/2] tcm_vhost " Nicholas A. Bellinger
2013-03-18 21:53   ` Michael S. Tsirkin [this message]
2013-03-18 22:19     ` Nicholas A. Bellinger
2013-03-18 22:19     ` Nicholas A. Bellinger
2013-03-19  0:33       ` Asias He
2013-03-19  9:36     ` Paolo Bonzini
2013-03-19 13:45       ` Michael S. Tsirkin
2013-03-19 13:47         ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130318215350.GA21091@redhat.com \
    --to=mst@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=nab@linux-iscsi.org \
    --cc=pbonzini@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=target-devel@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.