All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Julius Werner <jwerner@chromium.org>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	Lan Tianyu <tianyu.lan@intel.com>,
	Alan Stern <stern@rowland.harvard.edu>,
	Sameer Nanda <snanda@chromium.org>,
	Vincent Palatin <vpalatin@chromium.org>,
	Luigi Semenzato <semenzato@chromium.org>
Subject: Re: [PATCH] usb: Make USB persist default configurable
Date: Mon, 18 Mar 2013 17:06:56 -0700	[thread overview]
Message-ID: <20130319000656.GC6516@kroah.com> (raw)
In-Reply-To: <CAODwPW9c6NpDOzmh+q312qLn0fS+eQttQDGdCe0b2EigoJ9_PA@mail.gmail.com>

On Mon, Mar 18, 2013 at 05:02:19PM -0700, Julius Werner wrote:
> > Why can't you just revert this in userspace?  Isn't that easier than
> > doing a kernel patch and providing an option that we need to now
> > maintain for pretty much forever?
> 
> I could solve it in userspace, but that really feels like a hacky
> workaround and not a long term solution. It would mean that every new
> device starts with persist enabled and stays that way for a few
> milliseconds (maybe up to seconds if it's connected on boot), until
> userspace gets around to disable it again... opening the possibility
> for very weird race conditions and bugs with drivers/devices that
> don't work with persist.

What drivers/devices don't work with persist?  We need to know that now,
otherwise all other distros and users have problems, right?

> This default is a policy that really resides in the kernel, it has
> changed in the past, and since there is no definitive better choice
> for all cases I thought making it configurable is the right thing to
> do.

Too many options can be a bad thing.

I think Alan made this a "always on" option, so I'd like to get his
opinion on it.  Alan?

thanks,

greg k-h

  reply	other threads:[~2013-03-19  0:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-13 22:57 [PATCH] usb: Make USB persist default configurable Julius Werner
2013-03-18 23:09 ` Greg Kroah-Hartman
2013-03-19  0:02   ` Julius Werner
2013-03-19  0:06     ` Greg Kroah-Hartman [this message]
2013-03-19  1:04       ` Julius Werner
2013-03-19 14:56       ` Alan Stern
2013-03-19 15:06         ` Vincent Palatin
2013-03-19 15:42           ` Alan Stern
2013-03-19 17:29             ` Julius Werner
2013-03-20 14:49               ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130319000656.GC6516@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=jwerner@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=semenzato@chromium.org \
    --cc=snanda@chromium.org \
    --cc=stern@rowland.harvard.edu \
    --cc=tianyu.lan@intel.com \
    --cc=vpalatin@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.